Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable max block light for monster spawning #7129

Merged
merged 1 commit into from
Dec 22, 2021

Conversation

kennytv
Copy link
Member

@kennytv kennytv commented Dec 16, 2021

So people can revert this to how it was before 1.18
PaperMC/PaperDocs#138

Not using Math.max so it's obvious 0 is the Vanilla default when looking at code, used when the config is set to -1

@kennytv kennytv requested a review from a team as a code owner December 16, 2021 08:54
Copy link
Contributor

@lynxplay lynxplay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this go into the game-mechanics section of the world config ? Would fit pretty well there imo

@kennytv
Copy link
Member Author

kennytv commented Dec 16, 2021

Uh not really, it'd be the only mob spawning option in there then

@lynxplay
Copy link
Contributor

Uh not really, it'd be the only mob spawning option in there then

Pillager spawning is also in there isn't it ? But I digress, would fit just as well into the enormous amount of other random options that modify game mechanics but are not in the game mechanics section.

Copy link
Member

@jpenilla jpenilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@kennytv kennytv merged commit 10bfb63 into master Dec 22, 2021
@kennytv kennytv deleted the pr/monster-spawning branch December 22, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants