Pass through packets in config state #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electronicboy
approved these changes
May 23, 2024
R00tB33rMan
pushed a commit
to GemstoneGG/Velocity-CTD
that referenced
this pull request
May 23, 2024
R00tB33rMan
pushed a commit
to GemstoneGG/Velocity-CTD
that referenced
this pull request
May 23, 2024
qyl27
pushed a commit
to MeowCraftMC/Velocity
that referenced
this pull request
Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 1.20.5 there's an additional "handshake" when the client enters the configuration state.
If there's no connection in flight, the
play:serverbound/minecraft:configuration_acknowledgedemitted by the client isn't passed through to the backend server. This means the backend server won't start sending the rest of the registry data to the client, thus the client ends up in an infinite "Reconfiguring... " screen.In 99% of normal use cases there will be a connection in flight, but I sadly ran into a case where there wasn't a connection in flight. This PR solves this issue by just passing through the packet if there's no connection in flight.