feat: Add basic API for server links #1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RealBauHD
suggested changes
Jun 13, 2024
proxy/src/main/java/com/velocitypowered/proxy/connection/client/ConnectedPlayer.java
Outdated
Show resolved
Hide resolved
alexdev03
reviewed
Jun 13, 2024
alexdev03
reviewed
Jun 13, 2024
|
@alexdev03 The link is checked in the constructor above the static methods - hence is not needed twice. |
4drian3d
approved these changes
Jun 16, 2024
powercasgamer
approved these changes
Jun 18, 2024
qyl27
pushed a commit
to MeowCraftMC/Velocity
that referenced
this pull request
Jul 6, 2024
* feat: add basic server links API * refactor: more precondition checking on links * refactor: remove whitespace * refactor: adjust method order, JDs in ServerLink * refactor: remove "throws" from constructors * refactor: add @NotNull annotations * refactor: requested changes * refactor: just use `List#copyOf`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a (very simple) API for setting a list of server links to display to the client with either built-in or component labels. Strings for URLs as is the case in the resource pack API.
I was thinking about doing something more complex with a builder or something, but I'm not sure it's really needed in this case?