Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A couple of fixes for handling of secure chat #1366

Merged
merged 9 commits into from
Jul 5, 2024
Merged

A couple of fixes for handling of secure chat #1366

merged 9 commits into from
Jul 5, 2024

Commits on Jul 3, 2024

  1. Refactor ChatQueue to track and expose general chat state

    @Gegy
    Gegy committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    41d76f5 View commit details
    Browse the repository at this point in the history

  2. Remove unneeded check 

    SessionCommandHandler is only constructed for >= 1.19.3.
    @Gegy
    Gegy committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    b518aae View commit details
    Browse the repository at this point in the history

  3. Extract common command handler paths

    @Gegy
    Gegy committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    cd4a863 View commit details
    Browse the repository at this point in the history

  4. Don't require command to be signed to pass it through as-is

    @Gegy
    Gegy committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    f97b47b View commit details
    Browse the repository at this point in the history

  5. Explicitly reject consuming signed command when denied by event 

    This would fail down the line anyway due to inconsistent chat state (if holding a 'last seen' update)
    @Gegy
    Gegy committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    43524da View commit details
    Browse the repository at this point in the history

  6. Capture a consistent and reusable 'last seen' state for use in comman… 

    …d packets
    @Gegy
    Gegy committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    2802105 View commit details
    Browse the repository at this point in the history

  7. Fix: pass through last seen update in a few missing places 

    This is hardly useful in the case of signed player chat messages, as these fundamentally cannot be spoofed or modified - however, for any unsigned input (particularly commands without any signed arguments), 'last seen' updates are still required and should be passed through in a consistent state.
    @Gegy
    Gegy committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    f6950d1 View commit details
    Browse the repository at this point in the history

  8. Fix: only treat command as signed if it has signatures 

    The Vanilla client will send 'last seen' even if the message is not signed, so this is much stricter than it needs to be. This should allow commands without any signed arguments to be modified/consumed by the proxy.
    @Gegy
    Gegy committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    e4b0364 View commit details
    Browse the repository at this point in the history

  9. Don't forward chat acknowledgement if the client didn't acknowledge a… 

    …ny chat
    @Gegy
    Gegy committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    c1b3ae6 View commit details
    Browse the repository at this point in the history