Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exception while serializing JsonArray #1426

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Fix exception while serializing JsonArray #1426

merged 1 commit into from
Sep 11, 2024

Conversation

nostalfinals
Copy link
Contributor

Recently I encountered a issue with SystemChatPacket:

io.netty.handler.codec.EncoderException: java.lang.ClassCastException: class com.google.gson.internal.LazilyParsedNumber cannot be cast to class java.lang.Integer (com.google.gson.internal.LazilyParsedNumber is in unnamed module of loader 'app'; java.lang.Integer is in module java.base of loader 'bootstrap')
        at io.netty.handler.codec.MessageToByteEncoder.write(MessageToByteEncoder.java:125) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.channel.AbstractChannelHandlerContext.invokeWrite0(AbstractChannelHandlerContext.java:893) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.channel.AbstractChannelHandlerContext.invokeWrite(AbstractChannelHandlerContext.java:875) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:984) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:868) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.handler.codec.MessageToMessageEncoder.write(MessageToMessageEncoder.java:113) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.channel.AbstractChannelHandlerContext.invokeWrite0(AbstractChannelHandlerContext.java:893) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.channel.AbstractChannelHandlerContext.invokeWrite(AbstractChannelHandlerContext.java:875) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:984) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:868) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.channel.DefaultChannelPipeline.write(DefaultChannelPipeline.java:1015) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.channel.AbstractChannel.write(AbstractChannel.java:301) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at org.geysermc.geyser.network.netty.ChannelWrapper.write(ChannelWrapper.java:209) ~[?:?]
        at com.velocitypowered.proxy.connection.MinecraftConnection.delayedWrite(MinecraftConnection.java:248) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at com.velocitypowered.proxy.connection.backend.BackendPlaySessionHandler.handleGeneric(BackendPlaySessionHandler.java:449) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at com.velocitypowered.proxy.connection.MinecraftConnection.channelRead(MinecraftConnection.java:154) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at com.velocitypowered.proxy.protocol.netty.AutoReadHolderHandler.channelRead(AutoReadHolderHandler.java:57) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:442) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at com.velocitypowered.proxy.protocol.netty.MinecraftDecoder.tryDecode(MinecraftDecoder.java:91) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at com.velocitypowered.proxy.protocol.netty.MinecraftDecoder.channelRead(MinecraftDecoder.java:60) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:286) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:442) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:346) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:318) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:440) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.channel.epoll.AbstractEpollStreamChannel$EpollStreamUnsafe.epollInReady(AbstractEpollStreamChannel.java:800) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:509) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:407) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at java.base/java.lang.Thread.run(Thread.java:1583) [?:?]
Caused by: java.lang.ClassCastException: class com.google.gson.internal.LazilyParsedNumber cannot be cast to class java.lang.Integer (com.google.gson.internal.LazilyParsedNumber is in unnamed module of loader 'app'; java.lang.Integer is in module java.base of loader 'bootstrap')
        at com.velocitypowered.proxy.protocol.packet.chat.ComponentHolder.serialize(ComponentHolder.java:183) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at com.velocitypowered.proxy.protocol.packet.chat.ComponentHolder.serialize(ComponentHolder.java:147) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at com.velocitypowered.proxy.protocol.packet.chat.ComponentHolder.getBinaryTag(ComponentHolder.java:109) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at com.velocitypowered.proxy.protocol.packet.chat.ComponentHolder.write(ComponentHolder.java:295) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at com.velocitypowered.proxy.protocol.packet.chat.SystemChatPacket.encode(SystemChatPacket.java:56) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at com.velocitypowered.proxy.protocol.netty.MinecraftEncoder.encode(MinecraftEncoder.java:54) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at com.velocitypowered.proxy.protocol.netty.MinecraftEncoder.encode(MinecraftEncoder.java:32) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        at io.netty.handler.codec.MessageToByteEncoder.write(MessageToByteEncoder.java:107) ~[server.jar:3.3.0-SNAPSHOT (git-3c23ee75-b430)]
        ... 55 more

After diving into the code, I found that ComponentHolder's JsonArray serialization cannot handle type correctly:

switch (listType.id()) {
case 1://BinaryTagTypes.BYTE:
    byte[] bytes = new byte[jsonArray.size()];
    for (int i = 0; i < bytes.length; i++) {
        bytes[i] = (Byte) jsonArray.get(i).getAsNumber();
    }

    return ByteArrayBinaryTag.byteArrayBinaryTag(bytes);
case 3://BinaryTagTypes.INT:
    int[] ints = new int[jsonArray.size()];
    for (int i = 0; i < ints.length; i++) {
        ints[i] = (Integer) jsonArray.get(i).getAsNumber();
    }

    return IntArrayBinaryTag.intArrayBinaryTag(ints);
case 4://BinaryTagTypes.LONG:
    long[] longs = new long[jsonArray.size()];
    for (int i = 0; i < longs.length; i++) {
        longs[i] = (Long) jsonArray.get(i).getAsNumber();
    }

    return LongArrayBinaryTag.longArrayBinaryTag(longs);
case 10://BinaryTagTypes.COMPOUND:
    tagItems.replaceAll(tag -> {
        if (tag.type() == BinaryTagTypes.COMPOUND) {
            return tag;
        } else {
            return CompoundBinaryTag.builder().put("", tag).build();
        }
    });
    break;
}

The return value of JsonElement#getAsNumber could be a instance of LazilyParsedNumber, so it cannot be cast to Integer.
I replaced the explicit cast to corresponding method such as Number#intValue to solve this problem.

@nostalfinals nostalfinals marked this pull request as draft September 11, 2024 14:12
@nostalfinals nostalfinals marked this pull request as ready for review September 11, 2024 14:32
@kashike kashike self-assigned this Sep 11, 2024
@kashike kashike merged commit 0cd069e into PaperMC:dev/3.0.0 Sep 11, 2024
1 check passed
@nostalfinals nostalfinals deleted the dev/fix-json-serialize branch September 12, 2024 00:52
pull bot pushed a commit to WiIIiam278/Velocity that referenced this pull request Sep 13, 2024
@nostalfinals @pull
Fix exception while serializing JsonArray (PaperMC#1426)
1d40c10
jonesdevelopment added a commit to jonesdevelopment/sonar that referenced this pull request Sep 14, 2024
@jonesdevelopment
Fix exception while serializing JsonArray (PaperMC/Velocity#1426)
a1e4ea3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4drian3d 4drian3d 4drian3d approved these changes

@kashike kashike kashike approved these changes

Assignees

@kashike kashike

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nostalfinals @kashike @4drian3d