Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ShutdownCommand message styling #1427

Open
wants to merge 1 commit into
base: dev/3.0.0
Choose a base branch
from

Conversation

456dev
Copy link

@456dev 456dev commented Sep 14, 2024

the docs specify the command as accepting json components, as well as minimessage
in the previous implementation, neither were true, as the minimessage deserialisation after parsing legacy escaped any tags internally.

This PR fixes that by only deserialising the string once before parsing it on.
due to this, legacy "&" support has been removed

to support parsing as both minimessage + json, parsing as json will only kick in if it looks like a valid json text component:

  • "plain format, starting with a quote."
  • {"text":"Object format, starting with a curly brace"}
  • ["Array format", {"text": "starting with a square bracket"}]

TODO: docs pr to document json format hinting, as well as more strongly say that it only works in velocities console.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants