Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumb links to all pages, category indexes #42

Merged
merged 3 commits into from
Apr 8, 2022

Conversation

e-im
Copy link
Contributor

@e-im e-im commented Mar 30, 2022

Fixes an issue @MiniDigger noticed with google crying about invalid breadcrumbs.

This is intentional on the end of Docusaurus, ref https://togithub.com/facebook/docusaurus/pull/6932. Possibly a better solution is just to remove the last breadcrumb. I'm not sure, as there is good rationale provided there.

@github-actions
Copy link

github-actions bot commented Mar 30, 2022

Your pull request has been made available for preview at:
https://papermc.github.io/docs-previews/pull/42/
Last deployed: 7090812.

@e-im e-im changed the title Breadcrumbs on all pages, category indexes Breadcrumb links to all pages, category indexes Mar 30, 2022
@e-im
Copy link
Contributor Author

e-im commented Apr 8, 2022

Still don't love this but it seems like the best solution I've found and is at least okayish. Don't see anything else being better.

@e-im e-im merged commit b070580 into PaperMC:main Apr 8, 2022
@e-im e-im deleted the breadcrumbs-link branch April 8, 2022 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant