fix: upgrade daypicker #7521
Merged
fix: upgrade daypicker #7521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Krick <[email protected]>
enriquesanchez
approved these changes
Dec 3, 2022
There was a problem hiding this comment.
This looks so much better than what we currently have 👍
I want to suggest two minor tweaks, but these are not critical and I don't think they should stop this fix from going out:
- The selected date number is not correctly centered inside the highlight circle
- This also happens in the current picker, but the title above the month and year (Change Due Date) should have a little more top-margin so there's more breathing room and is vertically centered.
Signed-off-by: Matt Krick <[email protected]>
|
OMG you're so fast! the un-centered circle bothers me, it might just be on my machien though. linux has a bug where things get off-centered by 1 pixel the padding i can fix! gave it an extra 8px on the top |
Signed-off-by: Matt Krick <[email protected]>
Signed-off-by: Matt Krick <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matt Krick [email protected]
Description
Daypicker icons weren't showing up for the last month since we removed the material icons font.
There was no way to inject an SVG inside the component without upgrading daypicker to v8.
After upgrading, the overall style changed, but tbh I like it more than before, so I just kept it & changed the colors to match our palette.
I moved the style sheet to the Action component so we only have to worry about it once.
Demo
Works on tasks & in meetings