Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ai-summary): discussion summary in meeting summary #7534

Merged
merged 22 commits into from
Dec 13, 2022
Merged

feat(ai-summary): discussion summary in meeting summary #7534

merged 22 commits into from
Dec 13, 2022

Conversation

nickoferrall
Copy link
Contributor

@nickoferrall nickoferrall commented Dec 6, 2022 •
edited
Loading

Fix #7488

Demo: https://www.loom.com/share/9dabdb277aca410bacf66fa85dcd5666

To test

  • Make sure you've added both the OPEN_AI_API_KEY and OPEN_AI_ORG_ID env vars
  • Add the aiSummary feature flag to the user
  • Create a retro, add a bunch of comments and tasks in the discussion threads
  • When you end the meeting, you should see a Discussion Summary in the meeting summary

@nickoferrall
add aiSummary to user feature flag
6779367
@nickoferrall
add aiSummary to user flag enum
2d41e74
@nickoferrall
show hardcoded topicSummary in meeting summary
4b39649
@nickoferrall
conditionally show ai summary in meeting summary
e8a3dd0
@nickoferrall
add gpt-3 generated topicSummary to discussStage
7fbbb60
@nickoferrall
get topic summary showing up in meeting summary
26e3d54
@nickoferrall
add gpt-3 summary to reflection group
fd99d71
@nickoferrall
remove topic summary from retro discuss stage
be89562
@nickoferrall
clean-up server manager
5a5c5fa
@nickoferrall
update the demo summary
29b16b8
@nickoferrall
update to text-davinci-003
9994682
@nickoferrall
check facilitator featureFlag
ea43024
@nickoferrall
remove summary from Discussion
441760d
@nickoferrall
use reflection plaintextContent
fbb7343
@nickoferrall
implement pr feedback
2ba2ee5
@nickoferrall
implement update discussion query and generate a discussion summary a…
2918b79 
…fter discuss stage is complete
@nickoferrall
handle completed stage in endRetro
112c7ca
@nickoferrall
show the discussion summary in the meeting summary
8555aeb
@github-actions github-actions bot added the size/m label Dec 6, 2022
@nickoferrall nickoferrall changed the title Feat: discussion summary in meeting summary feat: discussion summary in meeting summary Dec 6, 2022
@nickoferrall nickoferrall changed the title feat: discussion summary in meeting summary feat(ai-summary): discussion summary in meeting summary Dec 6, 2022
@nickoferrall nickoferrall marked this pull request as ready for review December 7, 2022 10:59
@nickoferrall nickoferrall requested review from igorlesnenko and removed request for tianrunhe December 7, 2022 11:01
@nickoferrall nickoferrall linked an issue Dec 7, 2022 that may be closed by this pull request
AI Summary: implement discussion summary in the meeting summary #7488
Closed
4 tasks
@nickoferrall nickoferrall requested review from igorlesnenko and removed request for igorlesnenko December 7, 2022 11:01
igorlesnenko
igorlesnenko approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@igorlesnenko igorlesnenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I wonder should we show some kind of spinner or loading indicator if summary is not ready yet?

@nickoferrall
Copy link
Contributor Author

Looks good! I wonder should we show some kind of spinner or loading indicator if summary is not ready yet?

Yeah, I think you're right! I've created an issue as I don't think it'll be straightforward: #7537

@nickoferrall nickoferrall mentioned this pull request Dec 8, 2022
Merged
5 tasks
Base automatically changed from feat/7471/topic-summary-in-meeting-summary to master December 8, 2022 17:38
Dschoordsch
Dschoordsch approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@Dschoordsch Dschoordsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good for now. I would like to update the summary once the API requests finished. Maybe we should add these to the meeting subscription and just send them once ready?

I haven't checked the email, but that would also miss these fields, right?

packages/server/postgres/migrations/1670328109485_addSummaryToDiscussion.ts Outdated
await client.connect()
await client.query(`
ALTER TABLE "Discussion"
DROP COLUMN "summary";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 IF EXISTS

@nickoferrall nickoferrall merged commit 3b4648a into master Dec 13, 2022
@nickoferrall nickoferrall deleted the feat/7488/discussion-summary-in-meeting-summary branch December 13, 2022 12:04
@nickoferrall
Copy link
Contributor Author

I would like to update the summary once the API requests finished. Maybe we should add these to the meeting subscription and just send them once ready?

Agreed! This issue should resolve that: #7537

I haven't checked the email, but that would also miss these fields, right?

In a later PR (#7543), I only send the email once the whole summary has been generated which means the discussion summary should also have been generated by then

@mattkrick mattkrick mentioned this pull request Dec 15, 2022
Closed
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dschoordsch Dschoordsch Dschoordsch approved these changes

@igorlesnenko igorlesnenko igorlesnenko approved these changes

Assignees
No one assigned
Labels
size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AI Summary: implement discussion summary in the meeting summary
3 participants
@nickoferrall @igorlesnenko @Dschoordsch