Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(standups): Auto-open response discussion based on query param #7546

Merged
merged 2 commits into from
Dec 12, 2022

Conversation

jmtaber129
Copy link
Contributor

@jmtaber129 jmtaber129 commented Dec 8, 2022

Description

If a responseId query param is present when the Team Prompt Meeting is initially rendered, try to find the corresponding response card, and open its discussion.

Update the in-app and email notifications for standup mentions to include this query param.

In the future, we could use this to enable share-ability by either adding "copy link" buttons to response cards and/or keeping the query param in-sync with open discussion drawers.

Marking this as one review required because this general pattern has already been approved by maintainers in #7225

Demo

In-app - https://www.loom.com/share/45eb8249c162428faceb75f42f6351c6
From email link - https://www.loom.com/share/399f00c8e8a047c4819411ca4d69f85d

Testing scenarios

  • Trigger a standup mention notification from user B to user A
  • Send notification email batch
  • Click the "see their response" link in user A's email, and confirm it auto-opens user B's response
  • Click the "see their response" link in user A's notifications dropdown, and confirm it auto-opens user B's response

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label One Review Required if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

@jmtaber129 jmtaber129 added the Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved label Dec 8, 2022
@github-actions github-actions bot added the size/s label Dec 8, 2022
Copy link
Contributor

@BartoszJarocki BartoszJarocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great, 🚢 it!

@BartoszJarocki BartoszJarocki merged commit 664dfc6 into master Dec 12, 2022
@BartoszJarocki BartoszJarocki deleted the jmtaber129/standup-shareable-response-link branch December 12, 2022 13:53
@mattkrick mattkrick mentioned this pull request Dec 15, 2022
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/s Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants