Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Git and Conversion #57

Merged
merged 5 commits into from
Apr 9, 2023
Merged

Changed Git and Conversion #57

merged 5 commits into from
Apr 9, 2023

Conversation

arroyoquiel
Copy link
Contributor

@arroyoquiel arroyoquiel commented Apr 9, 2023

Description

  • Moved Git install to the beginning.
  • Changed the Git install so it doesn't exit if you pressed no if you already had it installed.
  • Changed the conversion: It asks to convert a model. If user agrees, it converts using Python. If not, it skips.
  • On conversion failure, it reverts to original model.

Fixes #6
Fixes #18
Fixes #26
Fixes #52
Fixes #53

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Please put an x in the boxes that apply. You can also fill these out after creating the PR.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have tested this code locally, and it is working as intended
  • I have updated the documentation accordingly

Screenshots

cmd_zc6q5rL6sR

Changed the Git install so it doesn't exit if you pressed no if you already had it installed.
Changed the conversion: It asks to convert a model. If user agrees, it converts using Python. If not, it skips. On conversion failure, it reverts to original model.
Changed the Git install so it doesn't exit if you pressed no if you already had it installed.
Changed the conversion: It asks to convert a model. If user agrees, it converts using Python. If not, it skips. On conversion failure, it reverts to original model.
Removed some testing pauses and added some echo. for easier readability.
Changed the Git install so it doesn't exit if you pressed no if you already had it installed.
Changed the conversion: It asks to convert a model. If user agrees, it converts using Python. If not, it skips. On conversion failure, it reverts to original model.
Removed some testing pauses and added some echo. for easier readability.
Changed the Git install so it doesn't exit if you pressed no if you already had it installed.
Changed the conversion: It asks to convert a model. If user agrees, it converts using Python. If not, it skips. On conversion failure, it reverts to original model.
Removed some testing pauses and added some echo. for easier readability.
Moved Git install to the beginning.
Changed the Git install so it doesn't exit if you pressed no if you already had it installed.
Changed the conversion: It asks to convert a model. If user agrees, it converts using Python. If not, it skips. On conversion failure, it reverts to original model.
Removed some testing pauses and added some echo. for easier readability.
Copy link
Owner

@ParisNeo ParisNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verry cool

@ParisNeo ParisNeo merged commit e59430a into ParisNeo:main Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment