tests: Ignore failing test on PowerPC 64-bit #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NobodyXu
suggested changes
Apr 26, 2022
| @@ -419,8 +421,6 @@ fn test_to_compact_str() { | |||
| assert_int_MAX_to_compact_str!(isize); | |||
|
|
|||
| // Test specialisation for f32 and f64 using ryu | |||
There was a problem hiding this comment.
Actually, we just need to add cfg here to include all assert_eq for testing specialisation for f32 and f64 using ryu:
Suggested change
| // Test specialisation for f32 and f64 using ryu | |
| // Test specialisation for f32 and f64 using ryu | |
| #[cfg(all(target_arch = "powerpc64", target_pointer_width = "64"))] | |
| { |
compact_str/src/tests.rs
Outdated
| @@ -390,6 +390,8 @@ macro_rules! assert_int_MAX_to_compact_str { | |||
| } | |||
|
|
|||
| #[test] | |||
| // TODO: Fix bug in powerpc64, which is a little endian system | |||
There was a problem hiding this comment.
The tracking issue for this is rust-lang/rust#96306
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an issue with formatting floats on PowerPC Little Endian 64-bit, for now we'll ignore the relevant assertions for this platform to keep the X-Plat CI target high signal