Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PBID-69: Include iframe depth in the data object sent to nest #14

Merged
merged 2 commits into from
Feb 4, 2021
Merged

PBID-69: Include iframe depth in the data object sent to nest #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3fd567
Add iframe detection
victorigualada Feb 2, 2021
105b301
Remove forgotten .only
victorigualada Feb 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion modules/parrableIdSystem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,8 @@ function fetchId(configParams) {
const data = {
eid,
trackers: configParams.partner.split(','),
url: refererInfo.referer
url: refererInfo.referer,
isIframe: utils.inIframe(),
};

const searchParams = {
Expand Down
3 changes: 2 additions & 1 deletion test/spec/modules/parrableIdSystem_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,8 @@ describe('Parrable ID System', function() {
expect(data).to.deep.equal({
eid: P_COOKIE_EID,
trackers: P_CONFIG_MOCK.params.partner.split(','),
url: getRefererInfo().referer
url: getRefererInfo().referer,
isIframe: true
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it true that tests run in an iframe? I didn't realize that

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test passes so..

});

server.requests[0].respond(200,
Expand Down