Skip to content
This repository has been archived by the owner on Mar 24, 2021. It is now read-only.

fix exception when messageset is too large for decode buffer #713

Merged
merged 1 commit into from
Aug 24, 2017

Conversation

emmettbutler
Copy link
Contributor

new exception does not inherit from ProtocolClientError, removing ambiguity about whether this error originated at the broker or the client

fixes #697

new exception does not inherit from ProtocolClientError, removing ambiguity about whether this error originated at the broker or the client

fixes #697
@codecov-io
Copy link

codecov-io commented Aug 24, 2017

Codecov Report

Merging #713 into master will increase coverage by 0.06%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #713      +/-   ##
==========================================
+ Coverage    84.1%   84.17%   +0.06%     
==========================================
  Files          26       26              
  Lines        3373     3375       +2     
  Branches      539      539              
==========================================
+ Hits         2837     2841       +4     
+ Misses        393      389       -4     
- Partials      143      145       +2
Impacted Files Coverage Δ
pykafka/exceptions.py 100% <100%> (ø) ⬆️
pykafka/protocol.py 96.66% <50%> (ø) ⬆️
pykafka/connection.py 77.65% <0%> (-2.13%) ⬇️
pykafka/simpleconsumer.py 83.08% <0%> (-0.25%) ⬇️
pykafka/balancedconsumer.py 90.26% <0%> (+0.29%) ⬆️
pykafka/cluster.py 71.73% <0%> (+0.43%) ⬆️
pykafka/rdkafka/producer.py 88.49% <0%> (+0.63%) ⬆️
pykafka/managedbalancedconsumer.py 80.55% <0%> (+0.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 878b1ff...92b75f3. Read the comment docs.

@emmettbutler emmettbutler merged commit 467c047 into master Aug 24, 2017
@emmettbutler emmettbutler deleted the bugfix/decode_failure_exception branch August 24, 2017 19:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please do not use Broker-side exceptions for Client-side errors
2 participants