Extend dependency error change in #2989 to remaining two dependency types #3445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #2989 made dependency errors look nicer, but only did it for positional parameters. This PR extends that to kwarg and inputs=... dependencies. PR #2989 describes these changes in more depth. This PR adds a type annotation onto DFK._unwrap_futures that drives this change - preventing _unwrap_futures from returning None task ids for failed dependencies and instead requiring the task IDs to be strings.
khk-globus
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR #2989 made dependency errors look nicer, but only did it for positional
parameters. This PR extends that to kwarg and inputs=... dependencies.
PR #2989 describes these changes in more depth.
This PR adds a type annotation onto DFK._unwrap_futures that drives this
change - preventing _unwrap_futures from returning None task ids for failed
dependencies and instead requiring the task IDs to be strings.
Type of change