Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add quorum queue compatibility #805

Merged
merged 6 commits into from
Apr 30, 2021
Merged

Add quorum queue compatibility #805

merged 6 commits into from
Apr 30, 2021

Conversation

timbussmann
Copy link
Contributor

@timbussmann timbussmann commented Apr 26, 2021 •
edited by andreasohlund
Loading

Connects to #556 to bring compatibility for Version 6:

  • Allow endpoints to "connect" (aka not fail installation) to quorum audit/error queues
  • Allows endpoints to consume from quorum input (aka not fail installation) queues.
    • This use case is primarily designed for ServiceControl

Version 6 endpoints are not able to define the quorum queue mode themselves and therefore cannot create quorum queues but they can interact with existing quorum queues both as incoming as well as outgoing queues.

@timbussmann timbussmann changed the base branch from master to release-6.0 April 26, 2021 09:18
@WilliamBZA WilliamBZA self-requested a review April 30, 2021 07:05
@timbussmann timbussmann changed the base branch from release-6.0 to release-6.1 April 30, 2021 08:19
@timbussmann
Copy link
Contributor Author

timbussmann commented Apr 30, 2021 •
edited
Loading

retarget PR to release-6.1 branch

@timbussmann timbussmann marked this pull request as ready for review April 30, 2021 08:19
@timbussmann timbussmann merged commit 3ccb395 into release-6.1 Apr 30, 2021
@timbussmann timbussmann deleted the quorum-compatibility branch April 30, 2021 08:59
@timbussmann timbussmann changed the title Quorum compatibility for RabbitMQ transport v6 Quorum queue compatibility for RabbitMQ transport v6 Apr 30, 2021
@timbussmann timbussmann added this to the 6.1.0 milestone Apr 30, 2021
@andreasohlund andreasohlund changed the title Quorum queue compatibility for RabbitMQ transport v6 Quorum queue compatibility for RabbitMQ transport May 7, 2021
@andreasohlund andreasohlund changed the title Quorum queue compatibility for RabbitMQ transport Add quorum queue compatibility May 7, 2021
@dehghanfar
Copy link

@timbussmann @andreasohlund to use this do I need to go to the rabbitmq management tool and delete my queue and create a Quorum type queue with the same name as the queue that I just deleted?

@WilliamBZA
Copy link
Member

@dehghanfar Yes. This change means that endpoints can start when connecting to an existing quorum queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreasohlund andreasohlund andreasohlund approved these changes

@WilliamBZA WilliamBZA Awaiting requested review from WilliamBZA

Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
6.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@timbussmann @dehghanfar @WilliamBZA @andreasohlund