Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/ita update #626

Merged
merged 11 commits into from
Apr 24, 2020
Merged

Feature/ita update #626

merged 11 commits into from
Apr 24, 2020

Conversation

matteocrippa
Copy link
Contributor

@matteocrippa matteocrippa commented Apr 22, 2020 •
edited
Loading

Description

Improve italian localisation.

Minor cosmetic fixes after 0.9.5 test and add new key/value

Fixes #635
Fixes #632

@alpita-masurkar alpita-masurkar added the translation Need a native speaker to validate translation. Type "Approve" in comments section. label Apr 22, 2020
@alpita-masurkar
Copy link
Collaborator

@andreanuzzo can you review this?

andreanuzzo
andreanuzzo approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@andreanuzzo andreanuzzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine by me.

I wonder if we should replace autorità sanitarie with istituzioni sanitarie throughout the app text. @matteocrippa what do you think?

andreanuzzo
andreanuzzo previously approved these changes Apr 22, 2020
View reviewed changes
@matteocrippa
Copy link
Contributor Author

@andreanuzzo prolly both can fit, think I'm missing the context / user scenario for the database, I mean who's intended to provide that? Private healthcare entity, or public?
You know in italy if we refer to public are at the high level the ISS / Ministry of health, if we go at region level we deal with AST/ASL.

@andreanuzzo
Copy link
Contributor

I know, I'm Italian :D
I was thinking of common language. I think the most common word is istituzioni, at least from the articles I read. When I did the first translation I must have been distracted by the too many sources in English I've read so far.

Since we aren't collaborating at the national or regional level, yet, I would not mention the ISS/SSN/ASL etc. But probably would remove the autorità anyway. If official collaboration start, we can mention the institutions by name.

Can you make those changes as well?

@matteocrippa
Copy link
Contributor Author

@andreanuzzo migration done as suggested

@matteocrippa matteocrippa mentioned this pull request Apr 22, 2020
Closed
@alpita-masurkar alpita-masurkar mentioned this pull request Apr 24, 2020
Closed
@alpita-masurkar
Copy link
Collaborator

@matteocrippa Can you link #635 and #632 here?

@matteocrippa
Copy link
Contributor Author

done

@summetj
Copy link
Collaborator

summetj commented Apr 24, 2020

done

To make it appear in the sidebar correctly, I believe you need the keyword before each issue number in the PR description above:

Fixes #635
Fixes #632

@matteocrippa
Copy link
Contributor Author

yep worked, thx @summetj

@tstirrat tstirrat merged commit c8457d6 into Path-Check:develop Apr 24, 2020
@tstirrat
Copy link
Contributor

@alpita-masurkar @matteocrippa I updated this in Lokalise:

1 INSERTED 32 UPDATED 56 SKIPPED

@matteocrippa matteocrippa deleted the feature/ita_update branch April 24, 2020 21:05
tstirrat added a commit to alinelutz/covid-safe-paths that referenced this pull request Apr 24, 2020
@tstirrat
Merge branch 'develop' into pr/alinelutz/614
fde56a1 
* develop: (29 commits)
  Italian language updates (Path-Check#626)
  Remove authority selection from onboarding (Path-Check#679)
  v1.0.0 (Path-Check#669)
  Hide unintented "What does this mean?" message (Path-Check#668)
  BUGFIX: Add authority wasn't immediate (Path-Check#667)
  Polish the EULA (Path-Check#666)
  Add in a 6 hour time period between notifications (Path-Check#665)
  Add an EULA to the onboarding process (Path-Check#638)
  change to rawcdn for the versions.yaml file (Path-Check#662)
  Change naming in yaml, change yaml link (Path-Check#661)
  Add version check service (Path-Check#653)
  Add healthcare selection to onboarding flow (Path-Check#657)
  Add yaml file for version checking (Path-Check#658)
  Fix languages specific for history page (Path-Check#628)
  Lokalise: Translations update (ht) (Path-Check#655)
  Temporarily filter out extra languages in release mode (Path-Check#654)
  Suggest screenshots and fixed issues in PR template (Path-Check#637)
  Fix settings locale override storage (Path-Check#649)
  Disable google import on release builds (Path-Check#651)
  Revert "Fix missing settings icon on iOS 12.0.x (Path-Check#643)" (Path-Check#650)
  ...
tstirrat added a commit that referenced this pull request Apr 24, 2020
@tstirrat
Merge branch 'develop' into ts-cleanup-english-strings
c1d31c4 
* develop:
  Translation to Brazilian Portuguese (#614)
  Italian language updates (#626)
  Remove authority selection from onboarding (#679)
tstirrat added a commit that referenced this pull request Apr 24, 2020
@tstirrat
Merge branch 'develop' into ts-i18n-tosurl
dba2a00 
* develop: (24 commits)
  Translation to Brazilian Portuguese (#614)
  Italian language updates (#626)
  Remove authority selection from onboarding (#679)
  v1.0.0 (#669)
  Hide unintented "What does this mean?" message (#668)
  BUGFIX: Add authority wasn't immediate (#667)
  Polish the EULA (#666)
  Add in a 6 hour time period between notifications (#665)
  Add an EULA to the onboarding process (#638)
  change to rawcdn for the versions.yaml file (#662)
  Change naming in yaml, change yaml link (#661)
  Add version check service (#653)
  Add healthcare selection to onboarding flow (#657)
  Add yaml file for version checking (#658)
  Fix languages specific for history page (#628)
  Lokalise: Translations update (ht) (#655)
  Temporarily filter out extra languages in release mode (#654)
  Suggest screenshots and fixed issues in PR template (#637)
  Fix settings locale override storage (#649)
  Disable google import on release builds (#651)
  ...
tstirrat added a commit that referenced this pull request Apr 24, 2020
@tstirrat
Merge branch 'develop' into ts-i18n-pull-script
377428f 
* develop: (24 commits)
  Translation to Brazilian Portuguese (#614)
  Italian language updates (#626)
  Remove authority selection from onboarding (#679)
  v1.0.0 (#669)
  Hide unintented "What does this mean?" message (#668)
  BUGFIX: Add authority wasn't immediate (#667)
  Polish the EULA (#666)
  Add in a 6 hour time period between notifications (#665)
  Add an EULA to the onboarding process (#638)
  change to rawcdn for the versions.yaml file (#662)
  Change naming in yaml, change yaml link (#661)
  Add version check service (#653)
  Add healthcare selection to onboarding flow (#657)
  Add yaml file for version checking (#658)
  Fix languages specific for history page (#628)
  Lokalise: Translations update (ht) (#655)
  Temporarily filter out extra languages in release mode (#654)
  Suggest screenshots and fixed issues in PR template (#637)
  Fix settings locale override storage (#649)
  Disable google import on release builds (#651)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstirrat tstirrat tstirrat approved these changes

@andreanuzzo andreanuzzo andreanuzzo approved these changes

Assignees
No one assigned
Labels
translation Need a native speaker to validate translation. Type "Approve" in comments section.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typos in italian language translation Issue with Italian translation
5 participants
@matteocrippa @alpita-masurkar @andreanuzzo @summetj @tstirrat