Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up location after skipping the steps #721

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Set up location after skipping the steps #721

merged 1 commit into from
Apr 30, 2020

Conversation

denispapakul
Copy link
Contributor

Fixed #719 issue

How to test

Steps to reproduce

  • Launch App
  • Tap on "Get Started"
  • Accept the Licensing agreement
  • Tap Next twice and click on "Set up my phone"
  • Tap "Skip this step". Location access is shown in red cross mark
  • Tap on "Finish Setup" to navigate to Home screen
  • Navigate to Dashboard

Patrick-Erichsen
Patrick-Erichsen approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@Patrick-Erichsen Patrick-Erichsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that Location was Inactive on the dashboard after following the test instructions. Thanks for fixing a bug I didn't realize I introduced @denispapakul 👍

@Patrick-Erichsen Patrick-Erichsen merged commit 9b2c5b6 into Path-Check:develop Apr 30, 2020
tstirrat added a commit that referenced this pull request Apr 30, 2020
@tstirrat
Merge branch 'develop' into ts-pull-i18n
77d7fc2 
* develop:
  Set up location after skiping the steps (#721)
  App shows green icon when tracking is inactive (#722)
  Fix postinstall script on Windows (#720)
  Fix isVersionGreater and add tests (#726)
  update the upgrade version to 1.0.0, to match what is in the master branch and avoid mistaken forced upgrades. (#723)
  1.0.1 (#715)
  Put GPS filter behind dev flag (#714)
  Fix headline1 text cutoff (#712)
  Put auto sub behind dev flags (#711)
  remove default news url from News.js constructor (#704)
  Fix i18n placeholder for authorities (#709)
tstirrat added a commit that referenced this pull request Apr 30, 2020
@tstirrat
Merge branch 'develop' into ts-feature-flags
ea6557a 
* develop: (22 commits)
  Translation refresh (#708)
  updated issue template (#729)
  Set up location after skiping the steps (#721)
  App shows green icon when tracking is inactive (#722)
  Fix postinstall script on Windows (#720)
  Fix isVersionGreater and add tests (#726)
  update the upgrade version to 1.0.0, to match what is in the master branch and avoid mistaken forced upgrades. (#723)
  1.0.1 (#715)
  Put GPS filter behind dev flag (#714)
  Fix headline1 text cutoff (#712)
  Put auto sub behind dev flags (#711)
  remove default news url from News.js constructor (#704)
  Fix i18n placeholder for authorities (#709)
  Remove react-native-maps (#695)
  Fix e2e authority auto sub tests (#706)
  Fallback to English translations in e2e tests (#697)
  Add ja and fil languages (#700)
  Add a script to pull translations from lokalise (#641)
  Really really push to lokalise (#699)
  Run lokalize push on merge into develop (#698)
  ...
tstirrat added a commit that referenced this pull request Apr 30, 2020
@tstirrat
Merge branch 'develop' into ts-eula-i18n
ec6a1a7 
* develop:
  Translation refresh (#708)
  updated issue template (#729)
  Set up location after skiping the steps (#721)
  App shows green icon when tracking is inactive (#722)
  Fix postinstall script on Windows (#720)
  Fix isVersionGreater and add tests (#726)
  update the upgrade version to 1.0.0, to match what is in the master branch and avoid mistaken forced upgrades. (#723)
  1.0.1 (#715)
  Put GPS filter behind dev flag (#714)
  Fix headline1 text cutoff (#712)
  Put auto sub behind dev flags (#711)
tstirrat added a commit that referenced this pull request May 2, 2020
@tstirrat
Merge branch 'develop' into ts-icon-button
0a217c8 
* develop:
  Recommend PR best practices in PR template (#750)
  Add eslint react-hooks checks (#751)
  iOS: Added local notification in terminate function. (#521)
  Update dev README (#705)
  Better error logging in Google import (#703)
  Remove rebasing from suggestions in CONTRIBUTING.md (#724)
  Translation refresh (#708)
  updated issue template (#729)
  Set up location after skiping the steps (#721)
  App shows green icon when tracking is inactive (#722)
  Fix postinstall script on Windows (#720)
  Fix isVersionGreater and add tests (#726)
  update the upgrade version to 1.0.0, to match what is in the master branch and avoid mistaken forced upgrades. (#723)
  1.0.1 (#715)
  Put GPS filter behind dev flag (#714)
  Fix headline1 text cutoff (#712)
  Put auto sub behind dev flags (#711)
  remove default news url from News.js constructor (#704)
  Fix i18n placeholder for authorities (#709)
tstirrat added a commit that referenced this pull request May 2, 2020
@tstirrat
Merge branch 'develop' into ts-theme-button
4b91a3e 
* develop: (60 commits)
  Recommend PR best practices in PR template (#750)
  Add eslint react-hooks checks (#751)
  iOS: Added local notification in terminate function. (#521)
  Update dev README (#705)
  Better error logging in Google import (#703)
  Remove rebasing from suggestions in CONTRIBUTING.md (#724)
  Translation refresh (#708)
  updated issue template (#729)
  Set up location after skiping the steps (#721)
  App shows green icon when tracking is inactive (#722)
  Fix postinstall script on Windows (#720)
  Fix isVersionGreater and add tests (#726)
  update the upgrade version to 1.0.0, to match what is in the master branch and avoid mistaken forced upgrades. (#723)
  1.0.1 (#715)
  Put GPS filter behind dev flag (#714)
  Fix headline1 text cutoff (#712)
  Put auto sub behind dev flags (#711)
  remove default news url from News.js constructor (#704)
  Fix i18n placeholder for authorities (#709)
  Remove react-native-maps (#695)
  ...
aputinski pushed a commit to safe-paths-contrib/covid-safe-paths that referenced this pull request May 6, 2020
Merge remote-tracking branch 'official/develop' into survey
734ad7a 
* official/develop: (110 commits)
  Consolidate to a single theme aware Button component (Path-Check#767)
  Fixed incorrect pull command. (Path-Check#769)
  Update README, etc for tripleblind -> Path-Check (Path-Check#768)
  HTML EULA translation workflow (Path-Check#710)
  Allowing setup on macOS/Darwin for Android only. (Path-Check#766)
  Add Danish to the list of languages. (Path-Check#765)
  Fixed the aspect ration on the icon and add links (Path-Check#763)
  Build time feature flags (Phase 1) (Path-Check#694)
  Extract theme aware <IconButton /> component (Path-Check#756)
  Latest i18n pull (Path-Check#755)
  Add language contribution info to contributing guide (Path-Check#754)
  Recommend PR best practices in PR template (Path-Check#750)
  Add eslint react-hooks checks (Path-Check#751)
  iOS: Added local notification in terminate function. (Path-Check#521)
  Update dev README (Path-Check#705)
  Better error logging in Google import (Path-Check#703)
  Remove rebasing from suggestions in CONTRIBUTING.md (Path-Check#724)
  Translation refresh (Path-Check#708)
  updated issue template (Path-Check#729)
  Set up location after skiping the steps (Path-Check#721)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Patrick-Erichsen Patrick-Erichsen Patrick-Erichsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@denispapakul @Patrick-Erichsen