Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rupture from Rupture Support Gem is applied multiple times when supporting more than one skill #8259

Open
3 tasks done
majochem opened this issue Aug 27, 2024 · 0 comments · May be fixed by #8320
Open
3 tasks done

Comments

@majochem
Copy link

Check version

  • I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

  • I've checked for duplicate open and closed issues by using the search function of the issue tracker

Check for support

  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).

What platform are you running Path of Building on?

Windows

What is the value from the calculation in-game?

Maximum Rupture stacks in game is 3 per enemy. Regardless of number of sources.

What is the value from the calculation in Path of Building?

In the current PoB version (2.48.2), if you support more than one skill with Rupture Support. Each skill will apply multiplicative "more" stats. Example: If you're using Lacerate supported by Rupture and have Rupture stacks set to 3, adding Rupture Support to Shield Charge is calculated as a significant damage boost.

Screenshot 1: One additional instance of Rupture application in calculation section

This is issue is even more extreme when it comes to minion skills. Minion skills appear to provide 3 separate Rupture stacks for each active skill they have, plus one for summoning the minion itself.

Example1: Summon Skeletons provides 145% more damage if supported by Rupture. 89% more for the Summon Skill itself and another 89% more for Default Attack.
Screenshot 2: Rupture Support on Summon Skeletons providing 145% more damage

Example2: Herald of Agony provides 540% more damage. 90% more for the base skill and another 90% more for Default Attack, Mortar, Tail Spike, and Cleave respectively.

Screenshot 3: Rupture Support on HoAg supposedly providing 540% more damage
Screenshot 4: HoAg providing 5 separate instances of 90% more damage in the bleed calculation

How to reproduce the issue

  1. Have skill that deals bleeding damage
  2. Support skill with Rupture Support
  3. Set # of Rupture Stacks to 3 in config
  4. Add another active skill to the skills tab
  5. Add Rupture Support to the second active skill
  6. Bleed DPS goes brrrrrrrrr

Character build code

https://pobb.in/Hrpfa_PeeKKN

Screenshots

image
image
image
image

majochem added a commit to majochem/PathOfBuilding that referenced this issue Sep 26, 2024
@majochem majochem linked a pull request Sep 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant