[ComposeApp] Improve touch region area of input fields, Remove focus from fields on sharing image #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@yogeshpaliyal nice one 👍🏻. Everything looks good, just a comment
| @@ -81,6 +82,7 @@ fun BasicNotyTextField( | |||
| ) | |||
| } | |||
| BasicTextField( | |||
| modifier = Modifier.fillMaxWidth(), | |||
There was a problem hiding this comment.
@yogeshpaliyal Let this modifier be provided from the function parameter so that we can configure it as per our need and reuse it.
Reuse modifier of this function and make it like this
BasicTextField(
modifier = modifier,
decorationBox = { inlineField ->
Box { // Move outer box to decorationbox
AnimatedVisibility(...) {}
inlineField()
}
}There was a problem hiding this comment.
@PatilShreyas Added textFieldModifier param in BasicNotyTextField
PatilShreyas
changed the title
PatilShreyas
added
hacktoberfest
PatilShreyas
approved these changes
Oct 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #284 , closes #283
Checklist