-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Implement feature: Pinning/Unpinning notes #539
[Android] Implement feature: Pinning/Unpinning notes #539
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Varsha-Kulkarni Thanks for raising this awesome PR 😃. The change is really nice 👍🏻. I have a few comments, let's discuss them.
...pp/composeapp/src/main/java/dev/shreyaspatil/noty/composeapp/component/action/NotyActions.kt
Outdated
Show resolved
Hide resolved
...roid/app/composeapp/src/main/java/dev/shreyaspatil/noty/composeapp/ui/screens/NotesScreen.kt
Outdated
Show resolved
Hide resolved
...pp/simpleapp/src/main/java/dev/shreyaspatil/noty/simpleapp/view/detail/NoteDetailFragment.kt
Outdated
Show resolved
Hide resolved
...mpleapp/src/main/java/dev/shreyaspatil/noty/simpleapp/view/notes/adapter/NotesListAdapter.kt
Outdated
Show resolved
Hide resolved
noty-android/app/src/main/java/dev/shreyaspatil/noty/view/viewmodel/NoteDetailViewModel.kt
Outdated
Show resolved
Hide resolved
noty-android/data/local/schemas/dev.shreyaspatil.noty.data.local.NotyDatabase/1.json
Outdated
Show resolved
Hide resolved
noty-android/data/local/src/main/java/dev/shreyaspatil/noty/data/local/DatabaseMigrations.kt
Outdated
Show resolved
Hide resolved
noty-android/data/local/src/main/java/dev/shreyaspatil/noty/data/local/DatabaseMigrations.kt
Outdated
Show resolved
Hide resolved
noty-android/data/local/src/main/java/dev/shreyaspatil/noty/data/local/dao/NotesDao.kt
Outdated
Show resolved
Hide resolved
...pository/src/test/java/dev/shreyaspatil/noty/repository/local/NotyLocalNoteRepositoryTest.kt
Show resolved
Hide resolved
Thanks so much @PatilShreyas. I will make the reviewed/required changes and update PR. |
…/simpleapp/view/notes/adapter/NotesListAdapter.kt Co-authored-by: Shreyas Patil <[email protected]>
…/simpleapp/view/detail/NoteDetailFragment.kt Co-authored-by: Shreyas Patil <[email protected]>
…ository/NotyNoteRepository.kt Co-authored-by: Shreyas Patil <[email protected]>
@Varsha-Kulkarni CI is failing because the |
noty-android/app/src/main/java/dev/shreyaspatil/noty/view/viewmodel/NoteDetailViewModel.kt
Outdated
Show resolved
Hide resolved
…model/NoteDetailViewModel.kt Co-authored-by: Shreyas Patil <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything Looks good to me 😃. Once CI is passed, would be happy to merge. Thanks for awesome PR 👍🏻.
Thanks to you for this opportunity to work on this awesome project:) |
I've read and understood the contributing guidelines;
https://github.com/patilshreyas/NotyKT/blob/master/CONTRIBUTING.md
Summary
Description for the changelog
A picture or screenshot regarding change
Checklist