Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Implement feature: Pinning/Unpinning notes #539

Merged

Conversation

Varsha-Kulkarni
Copy link
Contributor

@Varsha-Kulkarni Varsha-Kulkarni commented Oct 4, 2022

I've read and understood the contributing guidelines;
https://github.com/patilshreyas/NotyKT/blob/master/CONTRIBUTING.md

Summary

Description for the changelog

  • When app is logged in, existing notes can be pinned by navigating to Note Detail screen of simpleapp and composeapp.
  • When navigated to Note Detail screen, the note can be pinned by tapping on Pin (📌 ) option.
  • Pinned notes are placed at the top of the list retaining sort order based on note creation date.
  • pinned state is lost when synced with backend since Noty-api is not updated to support pinning yet.

A picture or screenshot regarding change

Screenshot_20221002-225849_Noty
Screenshot_20221002-225855_Noty
Screenshot_20221002-225900_Noty

Checklist

  • Build and linting is passing.
  • This change is not breaking existing flow of a system.
  • I have written test case for this change.
  • This change is tested from all aspects.
  • Implemented any new third-party library (Which not existed before this change).

@Varsha-Kulkarni Varsha-Kulkarni changed the title Pin notes #534 Pin notes Oct 4, 2022
@Varsha-Kulkarni Varsha-Kulkarni marked this pull request as draft October 5, 2022 07:32
Copy link
Owner

@PatilShreyas PatilShreyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Varsha-Kulkarni Thanks for raising this awesome PR 😃. The change is really nice 👍🏻. I have a few comments, let's discuss them.

@PatilShreyas PatilShreyas changed the base branch from master to v2.1.0 October 5, 2022 09:28
@PatilShreyas PatilShreyas changed the base branch from v2.1.0 to dev-v2.1.0 October 5, 2022 09:30
@Varsha-Kulkarni
Copy link
Contributor Author

Thanks so much @PatilShreyas. I will make the reviewed/required changes and update PR.

Varsha-Kulkarni and others added 3 commits October 5, 2022 16:48
…/simpleapp/view/notes/adapter/NotesListAdapter.kt

Co-authored-by: Shreyas Patil <[email protected]>
…/simpleapp/view/detail/NoteDetailFragment.kt

Co-authored-by: Shreyas Patil <[email protected]>
…ository/NotyNoteRepository.kt

Co-authored-by: Shreyas Patil <[email protected]>
@PatilShreyas PatilShreyas changed the base branch from dev-v2.1.0 to feature/pin-note October 5, 2022 12:34
@PatilShreyas
Copy link
Owner

@Varsha-Kulkarni CI is failing because the isVisible extension property is not imported in the class NotesListAdapter.

@PatilShreyas PatilShreyas changed the title Pin notes [Android] Implement feature: Pinning/Unpinning notes Oct 5, 2022
@Varsha-Kulkarni Varsha-Kulkarni marked this pull request as ready for review October 5, 2022 13:49
…model/NoteDetailViewModel.kt

Co-authored-by: Shreyas Patil <[email protected]>
Copy link
Owner

@PatilShreyas PatilShreyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything Looks good to me 😃. Once CI is passed, would be happy to merge. Thanks for awesome PR 👍🏻.

@Varsha-Kulkarni
Copy link
Contributor Author

Thanks to you for this opportunity to work on this awesome project:)

@PatilShreyas PatilShreyas merged commit 78a1a90 into PatilShreyas:feature/pin-note Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Android] Feature Request: Pin notes
2 participants