Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix directive for route active #357

Closed
wants to merge 1 commit into from
Closed

Fix directive for route active #357

wants to merge 1 commit into from

Conversation

ggaulard
Copy link
Contributor

Subscribe to the QueryList instead of the Router

@ggaulard
Fix directive for route active
b7e81be 
Subscribe to the QueryList instead of the Router
@PatrickJS
Copy link
Owner

what does it fix?

@ggaulard
Copy link
Contributor Author

ggaulard commented Mar 1, 2016

I've create a new PR with plunkr preview of the fix.

@ggaulard ggaulard closed this Mar 1, 2016
@MaxMood96 MaxMood96 mentioned this pull request Nov 5, 2022
Open
@MaxMood96 MaxMood96 mentioned this pull request Dec 25, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggaulard @PatrickJS