Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some updates I found useful #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yanivbl6
Copy link

hi, I tried working with this repository and found it useful for generating new datasets (thanks, by the way).

In order to get it to work I had to make a few changes I thought could be useful to others:

  1. np.imread was since deprecated, so I replaced it was imageio.imread for the same effect.
  2. get_ordered_folders() proved problematic when using the --every_nth option, so I replaced it with a scan of the folder.
  3. In addition, I wanted a dataset I can plug-and-train in existing pytorch networks, so I add an optional/example file that gives a TorchVision.Dataset class, based on the files generated by the scripts. It also have a "statistics" function that extract the mean/stderr per channel for normalization. It's not a production-level code by I am sure it can help some users.

I am running it at the moment and it seems to be training well.

@PatrykChrabaszcz
Copy link
Owner

Hi @yanivbl6

Thanks for your interest,

  1. np.imread was since deprecated, so I replaced it was imageio.imread for the same effect.

I would prefer to keep the old code, in the paper we explicitly mention which library version was used to generate the data.

As for the other changes I don't really have time to check if everything works as it should.

However, since your changes might be useful for others, here is what we could do:

You add them to your repository,
You give me short paragraph with the description and with a link to your repository and I add it to the README.md

Let me know what you think.

Cheers,
Patryk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants