Fix sveltejs#643

PaulBGD · Jun 16, 2017 · d44436c · d44436c
1 parent 30d855b
commit d44436c
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 4 deletions.
diff --git a/src/generators/dom/visitors/IfBlock.ts b/src/generators/dom/visitors/IfBlock.ts
@@ -271,9 +271,14 @@ function compound(
 		`);
 	}
 
-	block.builders.destroy.addLine(
+	block.builders.unmount.addLine(
 		`${if_name}{
 			${name}.unmount();
+		}`
+	);
+
+	block.builders.destroy.addLine(
+		`${if_name}{
 			${name}.destroy();
 		}`
 	);

diff --git a/test/js/samples/if-block-no-update/expected-bundle.js b/test/js/samples/if-block-no-update/expected-bundle.js
@@ -164,12 +164,14 @@ function create_main_fragment ( state, component ) {
 		},
 
 		unmount: function () {
+			{
+						if_block.unmount();
+					}
 			detachNode( if_block_anchor );
 		},
 
 		destroy: function () {
 			{
-						if_block.unmount();
 						if_block.destroy();
 					}
 		}

diff --git a/test/js/samples/if-block-no-update/expected.js b/test/js/samples/if-block-no-update/expected.js
@@ -29,12 +29,14 @@ function create_main_fragment ( state, component ) {
 		},
 
 		unmount: function () {
+			{
+						if_block.unmount();
+					}
 			detachNode( if_block_anchor );
 		},
 
 		destroy: function () {
 			{
-						if_block.unmount();
 						if_block.destroy();
 					}
 		}
@@ -116,4 +118,4 @@ SvelteComponent.prototype.teardown = SvelteComponent.prototype.destroy = functio
 	this._torndown = true;
 };
 
-export default SvelteComponent;
+export default SvelteComponent;
diff --git a/tmp/svelte-bench b/tmp/svelte-bench