Threshold check #229
Merged
Threshold check #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs: improve writing refactor: change order of checks style: fix formatting issues test: order by value test: use MIN_SD59x18
…SHOLD constant and add tests
|
Looks great now! Thanks very much for your contribution. Happy to increase the input rejection threshold to 100k. I will include this fix in the next release (v4.0.3) |
|
Happy to contribute and thanks for the help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #200
I've implemented the changes requested in this PR. However, I'm encountering a failure during the build due to fuzz tests on unchanged code. The issue is only occurring within the GitHub Actions workflow but test runs fine locally. So possibly due to foundry versions.
Error Details:
Reason: The
vm.assumecheatcode rejected too many inputs (65536 allowed)] testFuzz_Rshift(uint256, uint256) (runs: 7354, μ: 4038, ~: 4038)It seems that the fuzz test is reaching the maximum input rejection threshold.
To get the tests to pass I increased max_test_rejects to 100_000 Foundry documentation. The default is 65_536
Do you have any other suggestions?