perf: optimize "execute"

PaulRBerg · Jun 22, 2023 · 27479f6 · 27479f6
1 parent f4ac54b
commit 27479f6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/PRBProxy.sol b/src/PRBProxy.sol
@@ -89,9 +89,11 @@ contract PRBProxy is IPRBProxy {
     /// @inheritdoc IPRBProxy
     function execute(address target, bytes calldata data) external payable override returns (bytes memory response) {
         // Check that the caller is either the owner or an envoy with permission.
-        bool permission = registry.getPermissionByOwner({ owner: owner, envoy: msg.sender, target: target });
-        if (owner != msg.sender && !permission) {
-            revert PRBProxy_ExecutionUnauthorized({ owner: owner, caller: msg.sender, target: target });
+        if (owner != msg.sender) {
+            bool permission = registry.getPermissionByOwner({ owner: owner, envoy: msg.sender, target: target });
+            if (!permission) {
+                revert PRBProxy_ExecutionUnauthorized({ owner: owner, caller: msg.sender, target: target });
+            }
         }
 
         // Delegate call to the target contract, and handle the response.