Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Node.js #179

Merged
merged 7 commits into from
Dec 5, 2023
Merged

Switch to Node.js #179

merged 7 commits into from
Dec 5, 2023

Conversation

andreivladbrg
Copy link
Collaborator

Same rationale as here

build: install prb test as npm package
build: install forge as npm package
build: remove gitmodules
ci: install node js dependencies in build and test job
chore: update remappings accordingly
@andreivladbrg andreivladbrg force-pushed the build/include-test-utils-in-package branch from 44769e4 to 3043176 Compare November 16, 2023 16:33
package.json Outdated Show resolved Hide resolved
Copy link
Owner

@PaulRBerg PaulRBerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@PaulRBerg
Copy link
Owner

The Slither job is failing and I don't know why. I have asked for support here:

crytic/slither-action#44 (comment)

Copy link
Owner

@PaulRBerg PaulRBerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@PaulRBerg PaulRBerg mentioned this pull request Dec 5, 2023
@PaulRBerg PaulRBerg merged commit d3086c3 into main Dec 5, 2023
6 checks passed
@PaulRBerg PaulRBerg deleted the build/include-test-utils-in-package branch December 5, 2023 12:23
@PaulRBerg PaulRBerg changed the title Include test utils in NPM package Switch to Node.js Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants