-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version fix for MERRA data download #2888
Add version fix for MERRA data download #2888
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Is this a temporary bug that warrants adding an exception for a single month, or is this something that will be resolved and could be marked as a temporary hack?
- please update CHANGELOG with description of the change
My guess is that this is a permanent change in the MERRA data that is specific to that month. I would be very surprised if GESDISC (the DAAC that manages MERRA data) would change the URL. I think this is the correct fix, and if they do decide to change the URL later, it will warrant a new PR. I suspect the origin of this change is the MODIS outage that happened sometime around September 2020 that made the MERRA data assimilation pipeline do weird things, and there was some additional post processing they did to resolve those issues, hence version 401. But that's just a guess. |
This PR looks good to me. @KristinaRiemer looks like you just need to respond to @dlebauer request that you update the CHANGELOG |
Ready to merge once checks pass |
Thanks for doing that @dlebauer! |
MERRA data was not being downloaded for September 2020. This one month uses version 401 instead of 400 in its download URL. Thanks to @ashiklom for helping me figure this out!
Description
Motivation and Context
Review Time Estimate
Types of changes
Checklist: