Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version fix for MERRA data download #2888

Merged
merged 6 commits into from
Mar 17, 2022

Conversation

KristinaRiemer
Copy link
Contributor

@KristinaRiemer KristinaRiemer commented Nov 8, 2021

MERRA data was not being downloaded for September 2020. This one month uses version 401 instead of 400 in its download URL. Thanks to @ashiklom for helping me figure this out!

Description

Motivation and Context

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of .zenodo.json
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@dlebauer dlebauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Is this a temporary bug that warrants adding an exception for a single month, or is this something that will be resolved and could be marked as a temporary hack?
  • please update CHANGELOG with description of the change

@ashiklom
Copy link
Member

ashiklom commented Nov 9, 2021

Is this a temporary bug that warrants adding an exception for a single month, or is this something that will be resolved and could be marked as a temporary hack?

My guess is that this is a permanent change in the MERRA data that is specific to that month. I would be very surprised if GESDISC (the DAAC that manages MERRA data) would change the URL. I think this is the correct fix, and if they do decide to change the URL later, it will warrant a new PR.

I suspect the origin of this change is the MODIS outage that happened sometime around September 2020 that made the MERRA data assimilation pipeline do weird things, and there was some additional post processing they did to resolve those issues, hence version 401. But that's just a guess.

@mdietze
Copy link
Member

mdietze commented Mar 8, 2022

This PR looks good to me. @KristinaRiemer looks like you just need to respond to @dlebauer request that you update the CHANGELOG

@dlebauer
Copy link
Member

Ready to merge once checks pass

@mdietze mdietze merged commit ecfa16c into PecanProject:develop Mar 17, 2022
@KristinaRiemer KristinaRiemer deleted the download_merra_fix branch March 18, 2022 13:28
@KristinaRiemer
Copy link
Contributor Author

Thanks for doing that @dlebauer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants