Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some warnings and notes from PEcAn.MA package. #2956

Closed
wants to merge 23 commits into from

Conversation

nanu1605
Copy link
Collaborator

No description provided.

@nanu1605 nanu1605 changed the title Fix check warnings and notes from PEcAn.MA package. Fix somewarnings and notes from PEcAn.MA package. Jul 12, 2022
@nanu1605 nanu1605 changed the title Fix somewarnings and notes from PEcAn.MA package. Fix some warnings and notes from PEcAn.MA package. Jul 12, 2022
@nanu1605 nanu1605 requested a review from infotroph July 12, 2022 13:39
Copy link
Member

@infotroph infotroph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good work. I left a few suggestions for edits -- some of them you can apply directly with the "commit suggestion" button if the edit I proposed looks correct to you (if you do this, make sure to pull the result back from GitHub to your local branch before making other edits), others will need more manual changes from you.

I'll be offline again for the rest of this week and should be back to more regular Internet access starting on the 16th.

modules/meta.analysis/R/meta.analysis.R Outdated Show resolved Hide resolved
modules/meta.analysis/R/meta.analysis.summary.R Outdated Show resolved Hide resolved
modules/meta.analysis/R/meta.analysis.summary.R Outdated Show resolved Hide resolved
modules/meta.analysis/DESCRIPTION Outdated Show resolved Hide resolved
modules/meta.analysis/R/single.MA.R Outdated Show resolved Hide resolved
modules/meta.analysis/DESCRIPTION Outdated Show resolved Hide resolved
@nanu1605
Copy link
Collaborator Author

Hi @infotroph @Aariq @mdietze, Should I manually update the docker/depends/pecan.depends.R to clear the PR checks?

@mdietze
Copy link
Member

mdietze commented Jul 15, 2022

@nanu1605 the script itself includes the answer to your question

# autogenerated do not edit
# use scripts/generate_dependencies.R

Makefile.depends Outdated Show resolved Hide resolved
modules/meta.analysis/R/meta.analysis.summary.R Outdated Show resolved Hide resolved
@infotroph
Copy link
Member

All of these commits are also included in #2965, so we should merge that and close this PR, but I'm leaving it open (marked as draft to prevent accidental merging) until then for easy reference to the review discussions.

@infotroph
Copy link
Member

These changes have been merged as part of #2965

@infotroph infotroph closed this Jul 22, 2022
@nanu1605 nanu1605 deleted the meta_analysis branch July 22, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants