-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some warnings and notes from PEcAn.MA package. #2956
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good work. I left a few suggestions for edits -- some of them you can apply directly with the "commit suggestion" button if the edit I proposed looks correct to you (if you do this, make sure to pull the result back from GitHub to your local branch before making other edits), others will need more manual changes from you.
I'll be offline again for the rest of this week and should be back to more regular Internet access starting on the 16th.
Co-authored-by: Chris Black <[email protected]>
Co-authored-by: Chris Black <[email protected]>
Co-authored-by: Chris Black <[email protected]>
Hi @infotroph @Aariq @mdietze, Should I manually update the |
@nanu1605 the script itself includes the answer to your question
|
Co-authored-by: Chris Black <[email protected]>
Merge branch 'meta_analysis' of https://github.com/nanu1605/pecan into meta_analysis
Co-authored-by: Chris Black <[email protected]>
All of these commits are also included in #2965, so we should merge that and close this PR, but I'm leaving it open (marked as draft to prevent accidental merging) until then for easy reference to the review discussions. |
These changes have been merged as part of #2965 |
No description provided.