Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed some global variables in PEcAn.DB package #2971

Merged
merged 20 commits into from
Aug 1, 2022
Merged

Fixed some global variables in PEcAn.DB package #2971

merged 20 commits into from
Aug 1, 2022

Conversation

nanu1605
Copy link
Collaborator

No description provided.

@nanu1605 nanu1605 changed the title Fixed some global variables in PEcAn.DB Fixed some global variables in PEcAn.DB package Jul 20, 2022
@nanu1605
Copy link
Collaborator Author

will update this PR with time

@Aariq Aariq marked this pull request as draft July 20, 2022 13:49
@nanu1605
Copy link
Collaborator Author

@mdietze Are these changes ok?

@nanu1605 nanu1605 marked this pull request as ready for review July 20, 2022 18:03
@nanu1605 nanu1605 closed this Jul 21, 2022
@nanu1605 nanu1605 reopened this Jul 21, 2022
@nanu1605 nanu1605 marked this pull request as draft July 21, 2022 08:04
robkooper
robkooper previously requested changes Jul 21, 2022
View reviewed changes
base/db/R/query.prior.R Outdated Show resolved Hide resolved
@nanu1605 nanu1605 requested a review from robkooper July 21, 2022 15:00
infotroph
infotroph requested changes Jul 22, 2022
View reviewed changes
base/db/R/get.trait.data.pft.R Outdated Show resolved Hide resolved
base/db/R/query.prior.R Outdated Show resolved Hide resolved
infotroph
infotroph reviewed Jul 28, 2022
View reviewed changes
base/db/R/get.trait.data.R Outdated Show resolved Hide resolved
base/db/R/query.prior.R Outdated Show resolved Hide resolved
base/db/R/query.prior.R Outdated Show resolved Hide resolved
@nanu1605 nanu1605 marked this pull request as ready for review July 28, 2022 12:43
@nanu1605 nanu1605 requested a review from infotroph July 28, 2022 12:43
infotroph
infotroph requested changes Jul 31, 2022
View reviewed changes
base/db/R/query.dplyr.R Outdated Show resolved Hide resolved
base/db/R/query.dplyr.R Outdated Show resolved Hide resolved
base/db/R/utils_db.R Outdated Show resolved Hide resolved
base/db/R/utils_db.R Outdated Show resolved Hide resolved
base/db/R/utils_db.R Outdated Show resolved Hide resolved
nanu1605 and others added 2 commits July 31, 2022 12:41
nanu1605 and others added 3 commits July 31, 2022 12:41
mdietze
mdietze requested changes Jul 31, 2022
View reviewed changes
base/db/R/query.prior.R Outdated Show resolved Hide resolved
base/db/R/get.trait.data.pft.R Outdated Show resolved Hide resolved
base/db/R/get.trait.data.R Outdated Show resolved Hide resolved
@nanu1605
Copy link
Collaborator Author

nanu1605 commented Jul 31, 2022 •
edited
Loading

Sorry @mdietze, I used update to remove settings as a global variable but later @infotroph suggested to remove the lines containing the settings variable, I removed the lines but forgot to remove update from the files. I am updating them now

@dlebauer
Copy link
Member

dlebauer commented Aug 1, 2022

ready to be merged after tests pass; I dismissed @robkooper's requested changes which were no longer applicable after deciding not to pass the 'update' argument to the function.

@mdietze mdietze merged commit 1cc3d7f into PecanProject:develop Aug 1, 2022
@moki1202 moki1202 mentioned this pull request Aug 5, 2022
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlebauer dlebauer dlebauer left review comments

@moki1202 moki1202 moki1202 left review comments

@infotroph infotroph infotroph approved these changes

@mdietze mdietze mdietze approved these changes

@robkooper robkooper Awaiting requested review from robkooper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nanu1605 @dlebauer @infotroph @robkooper @mdietze @moki1202