-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace udunits2 with units #2989
Conversation
Looks like you need to run scripts/generate_dependencies.R |
@Aariq, all the CI checks are passing so I think the replacement worked |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woohoo! This is looking great.
Co-authored-by: Chris Black <[email protected]>
Co-authored-by: Chris Black <[email protected]>
Co-authored-by: Chris Black <[email protected]>
Co-authored-by: Chris Black <[email protected]>
Co-authored-by: Chris Black <[email protected]>
Co-authored-by: Chris Black <[email protected]>
@infotroph, The changes you suggested are done. Please review it once |
Maybe some simple tests for the new functions would be a good idea? A couple correctness tests and maybe a test that the output is indeed numeric (and not class "units") |
@nanu1605 This looks good, thank you. I support @Aariq's suggestion -- would you be willing to take a stab at some tests? I can help convert them into testthat format if you get stuck, but start by writing down the function calls you'd use for the correctness tests and how you'd decide the output is correct. |
@infotroph @Aariq Sure I will try writing the tests for |
@infotroph does this PR pass your requested changes? |
Co-authored-by: Chris Black <[email protected]>
Co-authored-by: Chris Black <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update changelog
@dlebauer should i update |
Sorry I closed it by mistake |
Co-authored-by: Chris Black <[email protected]>
Replace udunits2 with units package as udunits2 is an orphaned package.