Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace udunits2::ud.is.parseable with PEcAn.utils::unit_is_parseable #3002

Merged
merged 9 commits into from
Aug 5, 2022
Merged

Replace udunits2::ud.is.parseable with PEcAn.utils::unit_is_parseable #3002

merged 9 commits into from
Aug 5, 2022

Conversation

nanu1605
Copy link
Collaborator

@nanu1605 nanu1605 commented Aug 2, 2022

No description provided.

infotroph
infotroph requested changes Aug 5, 2022
View reviewed changes
Copy link
Member

@infotroph infotroph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! I made a few suggestions for clarity, but the code looks great overall.

base/utils/R/unit_is_parseable.R Outdated Show resolved Hide resolved
base/utils/R/unit_is_parseable.R Outdated Show resolved Hide resolved
base/utils/tests/testthat/test-unit_is_parseable.R Outdated Show resolved Hide resolved
base/utils/tests/testthat/test-unit_is_parseable.R Outdated Show resolved Hide resolved
@nanu1605 nanu1605 requested a review from infotroph August 5, 2022 17:04
Aariq
Aariq approved these changes Aug 5, 2022
View reviewed changes
Copy link
Collaborator

@Aariq Aariq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Is the plan to swap out ud.is.parseable in other PEcAn functions later/as needed?

@nanu1605
Copy link
Collaborator Author

nanu1605 commented Aug 5, 2022

As soon as this PR is merged i will start working on replacing ud.is.parseable

@mdietze mdietze merged commit 6019dd5 into PecanProject:develop Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moki1202 moki1202 moki1202 left review comments

@Aariq Aariq Aariq approved these changes

@infotroph infotroph infotroph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nanu1605 @infotroph @Aariq @moki1202 @mdietze