-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding SDA restart capability #3036
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d defintion for object "curr"
Merge branch 'GEFS_export' into sipnet_debug # Conflicts: # base/qaqc/DESCRIPTION # base/visualization/DESCRIPTION # modules/data.land/man/get_veg_module.Rd # modules/data.land/man/put_veg_module.Rd
Co-authored-by: Chris Black <[email protected]>
serbinsh
reviewed
Oct 21, 2022
serbinsh
reviewed
Oct 21, 2022
serbinsh
reviewed
Oct 21, 2022
serbinsh
reviewed
Oct 21, 2022
serbinsh
reviewed
Oct 21, 2022
serbinsh
reviewed
Oct 21, 2022
Wow @helge22a this is a LOT of work and a really nice PR! lots of great contributions here! I did my best to review but not sure i can dig deeper without a better understanding of running it all |
mdietze
approved these changes
Oct 25, 2022
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Condensing sda.enfk_MultiSite function with new functions metSplit, sda_matchparam, and build_X, added more comments to hopefully make this easier to work with. Now can run SDA at any time step (not only annual). Added new nimble model for running one site at a time through assimilation.
Motivation and Context
All changes necessary for scaling up SDA to continental scale/adding more data streams for NASA CMS project with @DongchenZ @serbinsh @mdietze @Qianyuxuan
Review Time Estimate
Types of changes
Checklist: