Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for #3080 (write.config.xml.ED2() not using <revision> tag correctly) #3081

Merged
merged 9 commits into from
Jan 19, 2023

Conversation

Aariq
Copy link
Collaborator

@Aariq Aariq commented Dec 22, 2022

Description

data() can't be used for internal datasets. The history.csv files are now stored as internal data and need to be accessed with history, history.r81, etc. This PR fixes some code in write.config.xml.ED2() that wasn't working.

Motivation and Context

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Aariq Aariq linked an issue Dec 22, 2022 that may be closed by this pull request
@Aariq Aariq requested a review from mdietze January 10, 2023 20:17
@mdietze mdietze merged commit 1898fc2 into develop Jan 19, 2023
@Aariq Aariq deleted the history-bug branch January 23, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

write.config.xml.ED2() doesn't use correct ED2 default dataset.
2 participants