-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced transform
function
#3097
Replaced transform
function
#3097
Conversation
Further occurrences of the @Aariq any specific reason for doing the below for packages not importing
Asking this because |
Just that it's sometimes a good idea to minimize the number of dependencies a package has. |
All instances of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking very good! Is it ready for full review or are you still adding changes?
Edit: you answered that above! approving now.
@@ -59,19 +59,19 @@ convert.samples.MAAT <- function(trait.samples, runid) { | |||
} | |||
if ("Ha.vcmax" %in% names(trait.samples)) { | |||
## Convert from kJ mol-1 to J mol-1 | |||
trait.samples <- transform(trait.samples, Ha.vcmax = PEcAn.utils::ud_convert(Ha.vcmax, "kJ", "J")) | |||
trait.samples$Ha.vcmax <- PEcAn.utils::ud_convert(trait.samples$Ha.vcmax, "kJ", "J") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm amused that the transform
's in this file were obviously intended to "save typing" but most of these lines are shorter without it!
Co-authored-by: Chris Black <[email protected]>
Description
The aim of this PR is to replace the use of
transform()
This PR fixes #2961
Motivation and Context
Review Time Estimate
Types of changes
Checklist: