Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional pfts argument to run.sensitivity.analysis() (fix/workaround for #3154) #3155

Merged
merged 13 commits into from
Apr 6, 2023

Conversation

Aariq
Copy link
Collaborator

@Aariq Aariq commented Mar 30, 2023

Description

Adds a pfts argument to run.sensitivity.analysis() to allow the user to specify a subset of PFTs in the settings object to run sensitivity analysis on.

Also prevents this function from dumping objects into the global environment (and possibly overwriting things without any warning) by specifying the environment for load()

Motivation and Context

Doing sensitivity analysis with a large number of PFTs generates a large number of runs and to save on compute time, I "manually" removed SA runs for PFTs I'm not interested in. run.sensitivity.analysis() interprets this as an there having been an error in model runs and doesn't generate all the files it is supposed to (in particular, no sensitivity.results.Rdata) (#3154).

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Aariq Aariq linked an issue Mar 31, 2023 that may be closed by this pull request
@Aariq Aariq marked this pull request as ready for review March 31, 2023 18:27
@Aariq Aariq requested review from mdietze and dlebauer March 31, 2023 18:27
@Aariq Aariq changed the title WIP: fix for #3154 Add optional pfts argument to run.sensitivity.analysis() (fix/workaround for #3154) Mar 31, 2023
@mdietze mdietze added this pull request to the merge queue Apr 6, 2023
Merged via the queue into develop with commit 778f8ed Apr 6, 2023
@Aariq Aariq deleted the sa-error branch April 10, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run.sensitivity.analysis() not creating sensitivity.results.Rdata
2 participants