Skip to content
This repository has been archived by the owner on Jul 11, 2024. It is now read-only.

Update Cards Styles #38

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Update Cards Styles #38

merged 2 commits into from
Mar 15, 2024

Conversation

Sweetdevil144
Copy link
Contributor

Fixes #34
Refactor layout for responsive design :

  • Implement two-column layout for larger screens
  • Switch to single-column on smaller devices for better usability

@allgandalf
Copy link
Collaborator

Haven't had time to test this locally, will test end of next week, @Sweetdevil144 , please bump me regarding the same :)

@allgandalf
Copy link
Collaborator

@eshantri , if you find time to review this in the meantime :)

@eshantri
Copy link
Collaborator

@GandalfGwaihir will review and test this locally by Friday. Thanks!

@eshantri eshantri self-requested a review March 2, 2024 14:15
@eshantri
Copy link
Collaborator

eshantri commented Mar 2, 2024

@Sweetdevil144 can you post a screenshot/gif of the result? Would be helpful.

@eshantri
Copy link
Collaborator

eshantri commented Mar 2, 2024

@GandalfGwaihir @Sweetdevil144 I tested the code locally, the grid issue is still there, along with weird arrangement of cards.

@Sweetdevil144
Copy link
Contributor Author

@Sweetdevil144 can you post a screenshot/gif of the result? Would be helpful.

Hey can you review this drive link to a video clips showing how the grid layout was laid out as I described. I think it works fine and the problem of irregular spacing is removed : https://drive.google.com/file/d/1T9uxoM4vti7ngUt3iD8P_SPqD_Ee3bc6/view?usp=sharing

It is also responsive for smaller screen size as shown in the video in this drive link : https://drive.google.com/file/d/1AijsMudf1ekRhXk8UlR8sm_HzHwGOf-2/view?usp=sharing

@Sweetdevil144
Copy link
Contributor Author

@GandalfGwaihir @Sweetdevil144 I tested the code locally, the grid issue is still there, along with weird arrangement of cards.

The goal of this issue (#34) was to remove irregular spacing between two card rowsehich was caused due to card layout. Can you explain a bit more with any 'image' example of what more changes would you like to be made for this? I'll improve the PR accordingly. @GandalfGwaihir can you checkout the drive links till then?

@Sweetdevil144
Copy link
Contributor Author

@GandalfGwaihir and @eshantri . Did you verify it?

@eshantri
Copy link
Collaborator

eshantri commented Mar 5, 2024 via email

@allgandalf
Copy link
Collaborator

@GandalfGwaihir and @eshantri . Did you verify it?

@eshantri will verify this,

Also :

Hey can you review this drive link to a video clips showing how the grid layout was laid out as I described. I think it works fine and the problem of irregular spacing is removed : https://drive.google.com/file/d/1T9uxoM4vti7ngUt3iD8P_SPqD_Ee3bc6/view?usp=sharing

It is also responsive for smaller screen size as shown in the video in this drive link : https://drive.google.com/file/d/1AijsMudf1ekRhXk8UlR8sm_HzHwGOf-2/view?usp=sharing

out of context: You can directly upload a video on github issues, no need to upload them to drive and share a link :) thanks

@allgandalf
Copy link
Collaborator

On going discussion on slack: https://pecanproject.slack.com/archives/D06DSNTTL9G/p1710178777928619

@Sweetdevil144
Copy link
Contributor Author

Cannot attach video_size>10mb, so attaching it via drive links.
Updated custom card size to make it uniform : Link

Copy link
Collaborator

@allgandalf allgandalf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I am satisfied over here, but again @eshantri can you approve the current implemented design also ig youalso have merge access so please merge this one if approved :)

@allgandalf
Copy link
Collaborator

Cannot attach video_size>10mb, so attaching it via drive links.

Is it, wow i was unaware all these years 😮

@eshantri
Copy link
Collaborator

eshantri commented Mar 15, 2024

Merging this. Thanks @Sweetdevil144 @GandalfGwaihir .

@eshantri eshantri merged commit 6d1427b into PecanProject:main Mar 15, 2024
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uneven grid distribution in People Page
3 participants