Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the index of this source handler #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change the index of this source handler #32

wants to merge 1 commit into from

Conversation

benvirus
Copy link
Contributor

This source handler should not be place at the 0 index since the videojs has H5 native handler. We should judge if the native handler can handle the source firstly.

This source handler should not be place at the 0 index since the videojs has H5 native handler. We should judge if the native handler can handle the source firstly.
@mrbar42
Copy link
Collaborator

mrbar42 commented Nov 29, 2017

@benvirus thanks for the PR

could you give some background for this change

@benvirus
Copy link
Contributor Author

benvirus commented Nov 29, 2017

@mrbar42 If set this handler at 0 index, when the Html5 tech instance invoke the selectSourceHandler method, this source handler will be judged before the native source handler of Html5. It should be better to judge native source handler firstly since we should use the native handler if it is support the source which was offered. Request For Comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants