Also disable the antlr runtim version check on the antlr 4 based Parser

Similar to the other version we rely on the CI to detect errors.
Pelagicore · Aug 1, 2024 · f6ec11c · f6ec11c
1 parent c26ec5a
commit f6ec11c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/qface/idl/parser/T4Lexer.py b/qface/idl/parser/T4Lexer.py
@@ -210,7 +210,9 @@ class T4Lexer(Lexer):
 
     def __init__(self, input=None, output:TextIO = sys.stdout):
         super().__init__(input, output)
-        self.checkVersion("4.10")
+        # Disable the version check for now as although there is a mismatch the Lexer seems to work fine.
+        # Rely on the weekly CI to make sure this keeps working also with later antlr versions.
+        # self.checkVersion("4.10")
         self._interp = LexerATNSimulator(self, self.atn, self.decisionsToDFA, PredictionContextCache())
         self._actions = None
         self._predicates = None

diff --git a/qface/idl/parser/T4Parser.py b/qface/idl/parser/T4Parser.py
@@ -246,7 +246,9 @@ class T4Parser ( Parser ):
 
     def __init__(self, input:TokenStream, output:TextIO = sys.stdout):
         super().__init__(input, output)
-        self.checkVersion("4.10")
+        # Disable the version check for now as although there is a mismatch the Lexer seems to work fine.
+        # Rely on the weekly CI to make sure this keeps working also with later antlr versions.
+        # self.checkVersion("4.10")
         self._interp = ParserATNSimulator(self, self.atn, self.decisionsToDFA, self.sharedContextCache)
         self._predicates = None