Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize output formatting with latest Mbed OS #103

Merged
merged 1 commit into from
Jul 23, 2021

Conversation

marcuschangarm
Copy link

"color-theme": {
"help": "Set color theme. 0 for readable, 1 for unobtrusive.",
"options": [0, 1],
"macro_name": "MBED_TRACE_COLOR_THEME",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the default should be the one we had previously

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would make it different from the default in Mbed OS.

The main reason for this change, and to have the default be more visible, is to help our FAEs (and me) when our customers send us screenshots of their logs or do screen sharing during remote debug sessions, so we can actually read the debug output and help our customers.

@0xc0170
Copy link

0xc0170 commented Jul 22, 2021

Can we proceed here, we would like to use this upstream repository with mbed-cli2.

@marcuschangarm
Copy link
Author

@0xc0170 I think we'll have to wait for @teetak01 to get back from vacation, I don't have merge rights on this repo.

@AnttiKauppila AnttiKauppila merged commit fd5b933 into master Jul 23, 2021
@AnttiKauppila AnttiKauppila deleted the mbed-os-sync branch July 23, 2021 06:55
@AnttiKauppila
Copy link
Contributor

@0xc0170 Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants