Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export proxy values #266

Merged
merged 1 commit into from
Mar 5, 2021
Merged

Export proxy values #266

merged 1 commit into from
Mar 5, 2021

Conversation

esajaa
Copy link
Contributor

@esajaa esajaa commented Feb 23, 2021

If not exported, these dont propagate to the pip3 or python3

If not exported, these dont propagate to the pip3 or python3
@esajaa esajaa requested a review from whygoyal February 23, 2021 13:07
@whygoyal
Copy link
Contributor

@esajaa Make sense but do we need to do this also of relay-term (nodejs based project)?

@JanneKiiskila
Copy link
Collaborator

JanneKiiskila commented Feb 23, 2021

I would assume we need these in all relevant places. Anything where we fetch something - it should be there.

For example here, too - I would assume at least.
https://github.com/PelionIoT/meta-pelion-edge/blob/master/recipes-connectivity/identity-tool/identity-tool_0.0.1.bb

I don't think we have a proxy setup available for us to test this?

Would it be all these files?

jankii01@ubuntu1804:~/mbed/meta-pelion-edge$ find . -type f -name "*.bb" | xargs grep -ir git | cut -d: -f1 | uniq
./recipes-core/ww-console-image-initramfs-init/ww-console-image-initramfs-init_1.0.bb
./recipes-core/images/console-image.bb
./recipes-core/images/ww-console-image-initramfs.bb
./recipes-connectivity/identity-tool/identity-tool_0.0.1.bb
./recipes-misc/info-tool/info-tool_2.0.0.bb
./recipes-wigwag/mbed-fcc/mbed-fcc_0.0.1.bb
./recipes-wigwag/edge-proxy/edge-proxy_git.bb
./recipes-wigwag/relay-term/relay-term_0.0.1.bb
./recipes-wigwag/devicedb/devicedb_0.0.12.bb
./recipes-wigwag/maestro-shell/maestro-shell_0.0.1.bb
./recipes-devtools/go/go-dep_0.5.4.bb
./meta-lmp-support/recipes-core/images/console-image-lmp.bb
./recipes-networking/cni/cni_git.bb
./recipes-containers/kubelet/kubelet_git.bb

@JanneKiiskila
Copy link
Collaborator

I would then assume, that all typical Yocto .bb files should have that same thing in those, by default.

https://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-bsp/efibootmgr/efibootmgr_17.bb

However, for example that one does not. What makes our .bb file so special?

@esajaa
Copy link
Contributor Author

esajaa commented Feb 24, 2021

@esajaa Make sense but do we need to do this also of relay-term (nodejs based project)?

I don't think so, at least I haven't heard any feedback that it doesn't work behind a proxy. I'm assuming it's because the recipe doesn't call npm directly, instead it uses npmsw fetcher, so it has some mechanism there to use the proxy variables

@esajaa
Copy link
Contributor Author

esajaa commented Feb 24, 2021

I would assume we need these in all relevant places. Anything where we fetch something - it should be there.

For example here, too - I would assume at least.
https://github.com/PelionIoT/meta-pelion-edge/blob/master/recipes-connectivity/identity-tool/identity-tool_0.0.1.bb

I don't think we have a proxy setup available for us to test this?

Would it be all these files?

jankii01@ubuntu1804:~/mbed/meta-pelion-edge$ find . -type f -name "*.bb" | xargs grep -ir git | cut -d: -f1 | uniq
./recipes-core/ww-console-image-initramfs-init/ww-console-image-initramfs-init_1.0.bb
./recipes-core/images/console-image.bb
./recipes-core/images/ww-console-image-initramfs.bb
./recipes-connectivity/identity-tool/identity-tool_0.0.1.bb
./recipes-misc/info-tool/info-tool_2.0.0.bb
./recipes-wigwag/mbed-fcc/mbed-fcc_0.0.1.bb
./recipes-wigwag/edge-proxy/edge-proxy_git.bb
./recipes-wigwag/relay-term/relay-term_0.0.1.bb
./recipes-wigwag/devicedb/devicedb_0.0.12.bb
./recipes-wigwag/maestro-shell/maestro-shell_0.0.1.bb
./recipes-devtools/go/go-dep_0.5.4.bb
./meta-lmp-support/recipes-core/images/console-image-lmp.bb
./recipes-networking/cni/cni_git.bb
./recipes-containers/kubelet/kubelet_git.bb

The HTTP_PROXY and HTTPS_PROXY variables get applied properly to most of the places. This most likely happens because the native handlers handle the proxies correctly. Calling pip directly in the recipe may be the thing that differentiates this recipe from others.

@JanneKiiskila
Copy link
Collaborator

Ok, @esajaa explanation about the pip3 makes perfect sense.

@JanneKiiskila JanneKiiskila merged commit 669d99b into dev Mar 5, 2021
@JanneKiiskila JanneKiiskila deleted the mbed_fcc_proxy branch March 5, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants