Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate-identity.sh - silence curl #45

Merged
merged 1 commit into from
Aug 17, 2023
Merged

generate-identity.sh - silence curl #45

merged 1 commit into from
Aug 17, 2023

Conversation

JanneKiiskila
Copy link
Contributor

@JanneKiiskila JanneKiiskila commented Aug 16, 2023 •
edited
Loading

This generates noise in the logs, we better silence curl.

Example:

elo 16 13:27:13 ubuntu-20-04 pelion-edge.identity[361975]:   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
elo 16 13:27:13 ubuntu-20-04 pelion-edge.identity[361975]:                                  Dload  Upload   Total   Spent    Left  Speed
elo 16 13:27:13 ubuntu-20-04 pelion-edge.identity[361975]: [158B blob data]
elo 16 13:27:13 ubuntu-20-04 pelion-edge.identity[361972]: Error: edge-core is not connected yet. Its status is- error. Exited with code 1.

Todos

  • Changelog updated
  • Run shellcheck or pysh-check before committing code - no more warnings than earlier (preferrably less)
  • Will tag a proper release, if need be.
  • Will update required recipes/builds as well.
  • Will update also the versions to relevant places:
    • edge-info/edge-info has the version number (around line 37)
    • identity-tools/VERSION has the version number as well.

@JanneKiiskila
generate-identity.sh - silence curl
2761b1b 
This generates noise in the logs, we better silence curl.
Add also Izuma as copyright holder.
petedyerarm
petedyerarm approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@petedyerarm petedyerarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JanneKiiskila JanneKiiskila merged commit 8663905 into master Aug 17, 2023
3 checks passed
@JanneKiiskila JanneKiiskila deleted the silence-curl branch August 17, 2023 07:03
@JanneKiiskila
Copy link
Contributor Author

JanneKiiskila commented Aug 17, 2023 •
edited
Loading

The checklist there is good. If only one read it.
#46 is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petedyerarm petedyerarm petedyerarm approved these changes

@jenia81 jenia81 Awaiting requested review from jenia81

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JanneKiiskila @petedyerarm