Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force D0 enabled during device select #59

Merged
merged 1 commit into from
Aug 31, 2017
Merged

Force D0 enabled during device select #59

merged 1 commit into from
Aug 31, 2017

Conversation

deepikabhavnani
Copy link

Resolves ARMmbed/mbed-os#4919

@geky Please verify and review

Copy link
Contributor

@geky geky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem like it will hurt anything. But out of curiousity why do we need this?

@deepikabhavnani
Copy link
Author

Few SPI devices expect a byte before chip select to indicate they are ready for next command, else might drop it. As per SD log, any command after CM25 was either treated as illegal command or was simply dropped.
In normal sequence it was usually CMD17 read block after multi byte transfer, file system does read and somehow device was able to recover during read sequence because host will wait for data. In case of odd bytes transfer CMD25 was followed by CMD24 which result in illegal command and device was unable to recover.

@deepikabhavnani deepikabhavnani mentioned this pull request Aug 30, 2017
@geky
Copy link
Contributor

geky commented Aug 31, 2017

Sounds good to me 👍

@geky geky merged commit 9439243 into PelionIoT:master Aug 31, 2017
@deepikabhavnani deepikabhavnani deleted the big_buf_issue branch September 6, 2017 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants