Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement detensorize-scf pass (for / if / while) #1075

Merged
merged 53 commits into from
Sep 24, 2024
Merged

Implement detensorize-scf pass (for / if / while) #1075

merged 53 commits into from
Sep 24, 2024

Commits on Aug 23, 2024

  1. WIP initial detensorize pass.

    @vincentmr
    vincentmr committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    4623fbe View commit details
    Browse the repository at this point in the history

  2. Clean up

    @vincentmr
    vincentmr committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    0696648 View commit details
    Browse the repository at this point in the history

  3. Fix op->getResult index.

    @vincentmr
    vincentmr committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    497bff4 View commit details
    Browse the repository at this point in the history

  4. Add scf.for pass.

    @vincentmr
    vincentmr committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    b127a27 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2024

  1. WIP

    @vincentmr
    vincentmr committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    2b143cb View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Dirty pass on scf.for

    @vincentmr
    vincentmr committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    31fafc3 View commit details
    Browse the repository at this point in the history

  2. Clean up scf pass.

    @vincentmr
    vincentmr committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    863e385 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. Remove detensor-if

    @vincentmr
    vincentmr committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    77a8a61 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Merge branch 'main' into detensorize_scf_pass

    @vincentmr
    vincentmr authored Sep 4, 2024
    Configuration menu
    Copy the full SHA
    969da5c View commit details
    Browse the repository at this point in the history

  2. Detensorize if.

    @vincentmr
    vincentmr committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    ca2612d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into detensorize_scf_pass

    @vincentmr
    vincentmr authored Sep 4, 2024
    Configuration menu
    Copy the full SHA
    4ccd71c View commit details
    Browse the repository at this point in the history

  4. Format

    @vincentmr
    vincentmr committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    739c4ca View commit details
    Browse the repository at this point in the history

  5. Add f_with_nested_scf test

    @vincentmr
    vincentmr committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    0e3a3b9 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Split DetensorizeSCFPass runOnOperation into two functions.

    @vincentmr
    vincentmr committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    9721f05 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Rewrite detensorizeForOp to support enums.

    @vincentmr
    vincentmr committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    8a7fa3b View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into detensorize_scf_pass

    @vincentmr
    vincentmr committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    931a1d8 View commit details
    Browse the repository at this point in the history

  3. Remove obsolete first_yield.

    @vincentmr
    vincentmr committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    625df76 View commit details
    Browse the repository at this point in the history

  4. Try OpConversionPattern

    @vincentmr
    vincentmr committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    d704afc View commit details
    Browse the repository at this point in the history

  5. Apply David's suggestions.

    @vincentmr
    vincentmr committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    81034da View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Refactor detensorizeIfOp.

    @vincentmr
    vincentmr committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    a095732 View commit details
    Browse the repository at this point in the history

  2. Attempt OpRewritePattern

    @vincentmr
    vincentmr committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    435fc6f View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into detensorize_scf_pass

    @vincentmr
    vincentmr committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    deafebd View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Basic detensorize-while

    @vincentmr
    vincentmr committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    9741fcb View commit details
    Browse the repository at this point in the history

  2. Clean up for/if.

    @vincentmr
    vincentmr committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    64e2c04 View commit details
    Browse the repository at this point in the history

  3. Clean up while.

    @vincentmr
    vincentmr committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    b51ac6f View commit details
    Browse the repository at this point in the history

  4. Add while test

    @vincentmr
    vincentmr committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    2b9fc20 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Refactor detensor test.

    @vincentmr
    vincentmr committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    29a1b66 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into detensorize_scf_pass

    @vincentmr
    vincentmr committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    79d5497 View commit details
    Browse the repository at this point in the history

  3. Apply David's suggestion on DetensorizeSCFTest.mlir.

    @vincentmr
    vincentmr committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    ca5cd7e View commit details
    Browse the repository at this point in the history

  4. Add if mlir test.

    @vincentmr
    vincentmr committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    5d088f5 View commit details
    Browse the repository at this point in the history

  5. Add for mlir test.

    @vincentmr
    vincentmr committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    60a9ce0 View commit details
    Browse the repository at this point in the history

  6. Remove MLIR related tests from test_detensorize.

    @vincentmr
    vincentmr committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    aacda7b View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Merge branch 'main' into detensorize_scf_pass

    @vincentmr
    vincentmr authored Sep 12, 2024
    Configuration menu
    Copy the full SHA
    8dc516f View commit details
    Browse the repository at this point in the history

  2. Make methods OpRewritePattern classes

    @vincentmr
    vincentmr committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    442b8bf View commit details
    Browse the repository at this point in the history

  3. Fix bug in DetensorizeIfOp

    @vincentmr
    vincentmr committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    5ee0cdf View commit details
    Browse the repository at this point in the history

  4. Restrain DetensorizeWhileOp

    @vincentmr
    vincentmr committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    4d7fadb View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/main' into detensorize_scf_pass

    @vincentmr
    vincentmr committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    00b1ac8 View commit details
    Browse the repository at this point in the history

  6. Update changelog.

    @vincentmr
    vincentmr committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    6cb7d1f View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Merge branch 'main' into detensorize_scf_pass

    @vincentmr
    vincentmr authored Sep 13, 2024
    Configuration menu
    Copy the full SHA
    98a9871 View commit details
    Browse the repository at this point in the history

  2. canonicalize after detensorize-scf

    @vincentmr
    vincentmr committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    758dace View commit details
    Browse the repository at this point in the history

  3. Split operand/result logic in whileop.

    @vincentmr
    vincentmr committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    bd5b1b4 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: David Ittah <[email protected]>
    @vincentmr @dime10
    vincentmr and dime10 authored Sep 13, 2024
    Configuration menu
    Copy the full SHA
    3b8355f View commit details
    Browse the repository at this point in the history

  5. Update changelog.

    @vincentmr
    vincentmr committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    ccd497e View commit details
    Browse the repository at this point in the history

  6. Update mlir/test/Catalyst/DetensorizeSCFTest.mlir 

    Co-authored-by: David Ittah <[email protected]>
    @vincentmr @dime10
    vincentmr and dime10 authored Sep 13, 2024
    Configuration menu
    Copy the full SHA
    10e8886 View commit details
    Browse the repository at this point in the history

  7. Move loop up

    @vincentmr
    vincentmr committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    589fd8d View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into detensorize_scf_pass

    @vincentmr
    vincentmr authored Sep 13, 2024
    Configuration menu
    Copy the full SHA
    8e62a93 View commit details
    Browse the repository at this point in the history

  9. Update changelog.

    @vincentmr
    vincentmr committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    1ab94d1 View commit details
    Browse the repository at this point in the history

  10. Merge remote-tracking branch 'origin/detensorize_scf_pass' into deten… 

    …sorize_scf_pass
    @vincentmr
    vincentmr committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    4732bb8 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Update the changelog

    @dime10
    dime10 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    b4890eb View commit details
    Browse the repository at this point in the history

  2. Simplify MLIR lit tests

    @dime10
    dime10 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    4a1dc28 View commit details
    Browse the repository at this point in the history

  3. Declare dependant passes

    @dime10
    dime10 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    1353d7f View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into detensorize_scf_pass

    @dime10
    dime10 authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    ca79aab View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Merge branch 'main' into detensorize_scf_pass

    @dime10
    dime10 authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    5a39f9f View commit details
    Browse the repository at this point in the history