[MLIR] Mark scatter pass as depending on func dialect #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erick-xanadu
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1216 +/- ##
==========================================
+ Coverage 97.90% 97.96% +0.05%
==========================================
Files 77 77
Lines 10932 11244 +312
Branches 967 967
==========================================
+ Hits 10703 11015 +312
Misses 180 180
Partials 49 49 ☔ View full report in Codecov by Sentry. |
erick-xanadu
added a commit
that referenced
this pull request
Oct 22, 2024
) **Context:** The current scatter lowering makes some assumptions and only handles a subset of the inputs. However, it is too optimistic and will attempt to convert inputs that it can't handle. In particular if there are more than one input update and result tensors, it will segfault. This condition may never happen but it is valid IR. It may never happen if another pass runs before that canonicalizes mhlo.scatter. However, it is good to emit an error in case the canonicalization was not run before. **Description of the Change:** Emit error instead of segfaulting **Benefits:** No segfaults **Possible Drawbacks:** None **Related GitHub Issues:** Depends on #1216
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: All MLIR transformations are required to register dialects if they produce operations or attributes from those dialects. The
--scatter-loweringpass producesfunc.funcops, but does not register the func dialect as a dependency.Description of the Change: Register the func dialect as a dependency.
Benefits: More correct.
Possible Drawbacks: None