Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast array gate parameters to list #126

Merged
merged 4 commits into from
Jan 29, 2021
Merged

Cast array gate parameters to list #126

merged 4 commits into from
Jan 29, 2021

Conversation

antalszava
Copy link
Contributor

Context

With the release of Qiskit 0.23.3 gate parameters cannot be arrays. This PR adds conversion from arrays to lists.

Note

This PR makes the device tests pass for the plugin.

@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #126 (e251076) into master (dfbf988) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #126   +/-   ##
=======================================
  Coverage   99.30%   99.30%           
=======================================
  Files           7        7           
  Lines         286      289    +3     
=======================================
+ Hits          284      287    +3     
  Misses          2        2           
Impacted Files Coverage Δ
pennylane_qiskit/qiskit_device.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfbf988...e251076. Read the comment docs.

@antalszava antalszava merged commit af673fa into master Jan 29, 2021
@antalszava antalszava deleted the list_as_par branch January 29, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants