Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove adding a verbose option to the run arguments #151

Merged
merged 2 commits into from
Aug 25, 2021
Merged

Conversation

antalszava
Copy link
Contributor

@antalszava antalszava commented Aug 25, 2021

Context

In QiskitDevice, a verbose option is being added by default to the keyword arguments to be passed to the backend. This has caused warnings when submitting jobs to IBMQ.

The lines that set the verbose to false have been added a while back in #44. Likely, this used to be a valid backend option, however, at the moment there Qiskit doesn't seem to support it.

Changes

Removes the addition of the verbose option.

Related issues

Closes #145

@antalszava
Copy link
Contributor Author

[ch7908]

@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #151 (5f616a4) into master (9e45d13) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
- Coverage   99.28%   99.28%   -0.01%     
==========================================
  Files           7        7              
  Lines         281      279       -2     
==========================================
- Hits          279      277       -2     
  Misses          2        2              
Impacted Files Coverage Δ
pennylane_qiskit/qiskit_device.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e45d13...5f616a4. Read the comment docs.

Copy link
Contributor

@albi3ro albi3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

Does this need a changelog entry?

@antalszava
Copy link
Contributor Author

@albi3ro good catch! Added one. Thank you

@josh146 josh146 merged commit cccdefb into master Aug 25, 2021
@josh146 josh146 deleted the no_verbose branch August 25, 2021 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UserWarning: verbose is not a recognized runtime option and may be ignored by the backend
3 participants