Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements.txt and requirements-ci.txt #212

Merged
merged 20 commits into from
May 5, 2022
Merged

Update requirements.txt and requirements-ci.txt #212

merged 20 commits into from
May 5, 2022

Conversation

rmoyard
Copy link
Contributor

@rmoyard rmoyard commented Apr 20, 2022

Context

The idea is to:

  • Pin strictly in the requirements.txt file;
  • Have no version pins in the requirements-ci.txt file (exceptions apply);
  • Pin strictly in the doc/requirements.txt file.

This way:

  • Users will have a combination of dependency versions for which our package should work (requirements.txt file);
  • On our CI, we see if a new version of a dependency breaks something (requirements-ci.txt file), but this doesn't affect users.

The same applies to the documentation requirements where the documentation build should continue to work even with new dependency versions being released.

Changes

Created an updated requirements.txt file by:

  1. Creating a clean conda environment;
  2. Installing the plugin with pip install -e .;

a) Saving the dependencies to a temporary req.txt file via pip freeze >> req.txt
b) Removing the PennyLane-Honeywell entry from req.txt;
4. Installing pytest and related packages and verifying that the test suite runs;
5. Making req.txt the new requirements.txt file.

  • requirements-ci.txt: created by copying requirements.txt and removing the pinnings (except for semantic versioning which is pinned in PennyLane's setup.py file),
  • doc/requirements.txt: created in a similar fashion to how requirements.txt created, just that make docs was being used for "installation".

@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #212 (90b731f) into master (f1d5ff7) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #212   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          292       292           
=========================================
  Hits           292       292           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1d5ff7...90b731f. Read the comment docs.

@antalszava
Copy link
Contributor

[sc-17333]

doc/requirements.txt Outdated Show resolved Hide resolved
doc/requirements.txt Outdated Show resolved Hide resolved
doc/requirements.txt Outdated Show resolved Hide resolved
doc/requirements.txt Outdated Show resolved Hide resolved
doc/requirements.txt Outdated Show resolved Hide resolved
@rmoyard rmoyard merged commit 5f4cddf into master May 5, 2022
@rmoyard rmoyard deleted the update_req branch May 5, 2022 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants