-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update requirements.txt
and requirements-ci.txt
#212
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #212 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 292 292
=========================================
Hits 292 292 Continue to review full report at Codecov.
|
[sc-17333] |
Jaybsoni
reviewed
Apr 21, 2022
puzzleshark
approved these changes
May 4, 2022
rmoyard
commented
May 4, 2022
rmoyard
commented
May 4, 2022
rmoyard
commented
May 4, 2022
rmoyard
commented
May 4, 2022
rmoyard
commented
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The idea is to:
requirements.txt
file;requirements-ci.txt
file (exceptions apply);doc/requirements.txt
file.This way:
requirements.txt
file);requirements-ci.txt
file), but this doesn't affect users.The same applies to the documentation requirements where the documentation build should continue to work even with new dependency versions being released.
Changes
Created an updated
requirements.txt
file by:conda
environment;pip install -e .
;a) Saving the dependencies to a temporary
req.txt
file viapip freeze >> req.txt
b) Removing the PennyLane-Honeywell entry from
req.txt
;4. Installing
pytest
and related packages and verifying that the test suite runs;5. Making
req.txt
the newrequirements.txt
file.requirements-ci.txt
: created by copyingrequirements.txt
and removing the pinnings (except forsemantic versioning
which is pinned in PennyLane'ssetup.py
file),doc/requirements.txt
: created in a similar fashion to howrequirements.txt
created, just thatmake docs
was being used for "installation".