Update code that is pending deprecation #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## fix-vqe-runtime #301 +/- ##
=================================================
Coverage 100.00% 100.00%
=================================================
Files 6 6
Lines 301 303 +2
=================================================
+ Hits 301 303 +2
|
timmysilv
commented
May 3, 2023
rmoyard
reviewed
May 4, 2023
There was a problem hiding this comment.
Thanks @timmysilv, great job 🥇 I have left a couple of comments. Sorry that you had to rework the test IBMQ test suite.
timmysilv
added a commit
that referenced
this pull request
May 5, 2023
* remove VQE program/uploader, use qiskit VQE * black * add qiskit-ibm-runtime to doc requirements * update docs * changelog * activate test; try to load token from env * update version stuff for bugfix release * Update code that is pending deprecation (#301) * add pytest.ini to fail on deprecation warnings * fix deprecation warnings from import while running tests * use the new runtime service * fix up ibmq tests * update docs * replace remaining qiskit.providers.aer stuff from docs * changelog * fix tracker and tests; ensure correct meta-keys are received * black * add runtime_secs to IBMQDevice * fix quasi_dists in Sampler.generate_samples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While much of the code still works (sometimes), this is to future-proof us when Qiskit changes the details of their API.
I am very sorry for the mess that is
test_ibmq.pyNote: I ran both
test_ibmq.pyandtest_runtime.pywith my token present, and then with it absent. All tests passed/skipped as expected in the respective scenario.Fixes #289