-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove retired VQE runner #313
Conversation
Codecov Report
@@ Coverage Diff @@
## master #313 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 315 314 -1
=========================================
- Hits 315 314 -1
|
setup.py
Outdated
@@ -22,7 +22,7 @@ | |||
long_description = fh.read() | |||
|
|||
requirements = [ | |||
"qiskit>=0.32", | |||
"qiskit>=0.32,<=0.42.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"qiskit>=0.32,<=0.42.1", | |
"qiskit>=0.42.1", |
Should it not be that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's to prevent this issue in a test:
qiskit.exceptions.QiskitError: "Error decomposing node of instruction 'rx': 'NoneType' object has no attribute 'global_phase'. Unable to define instruction 'u' in the basis."
Though @timmysilv, have you tried fixing the issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have not, but I figured this week isn't the best time to do it. i'll give it a shot today
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
turns out Qiskit/qiskit#9343 changed the behaviour of the "unroller" transpilation method option to account for target ops, and this broke RX badly. the intention of the test is only to show that we can pass custom transpilation options, so I've changed it to just use the "translator" option! those should pass with the latest qiskit (confirmed locally)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @timmysilv! Overall looks good to me. We can come back to deciding what we want to do here during the 0.33 cycle.
setup.py
Outdated
@@ -22,7 +22,7 @@ | |||
long_description = fh.read() | |||
|
|||
requirements = [ | |||
"qiskit>=0.32", | |||
"qiskit>=0.32,<=0.42.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's to prevent this issue in a test:
qiskit.exceptions.QiskitError: "Error decomposing node of instruction 'rx': 'NoneType' object has no attribute 'global_phase'. Unable to define instruction 'u' in the basis."
Though @timmysilv, have you tried fixing the issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you run the IBMQ integration test from this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
sadge
the CI error:
qiskit_ibm_runtime.exceptions.IBMInputValueError: 'The vqe and qaoa programs have been retired in the Qiskit Runtime service. Please visit https://qiskit.org/ecosystem/ibm-runtime for an introduction on Sessions and Primitives, and to access tutorials on how to execute VQE and QAOA using Qiskit Runtime Primitives.'
too much effort to do any more than this.
PS: I pinned the maximum Qiskit version because this test fails with Qiskit 0.43, sayingqiskit.exceptions.QiskitError: "Error decomposing node of instruction 'rx': 'NoneType' object has no attribute 'global_phase'. Unable to define instruction 'u' in the basis."
^ EDIT: just changed the test to transpile with other options instead