Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove retired VQE runner #313

Merged
merged 4 commits into from
Jun 22, 2023
Merged

Remove retired VQE runner #313

merged 4 commits into from
Jun 22, 2023

Conversation

timmysilv
Copy link
Contributor

@timmysilv timmysilv commented Jun 20, 2023

sadge

the CI error: qiskit_ibm_runtime.exceptions.IBMInputValueError: 'The vqe and qaoa programs have been retired in the Qiskit Runtime service. Please visit https://qiskit.org/ecosystem/ibm-runtime for an introduction on Sessions and Primitives, and to access tutorials on how to execute VQE and QAOA using Qiskit Runtime Primitives.'

too much effort to do any more than this.

PS: I pinned the maximum Qiskit version because this test fails with Qiskit 0.43, saying qiskit.exceptions.QiskitError: "Error decomposing node of instruction 'rx': 'NoneType' object has no attribute 'global_phase'. Unable to define instruction 'u' in the basis."

^ EDIT: just changed the test to transpile with other options instead

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #313 (1768781) into master (76be1e1) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #313   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          315       314    -1     
=========================================
- Hits           315       314    -1     
Impacted Files Coverage Δ
pennylane_qiskit/__init__.py 100.00% <ø> (ø)

setup.py Outdated
@@ -22,7 +22,7 @@
long_description = fh.read()

requirements = [
"qiskit>=0.32",
"qiskit>=0.32,<=0.42.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"qiskit>=0.32,<=0.42.1",
"qiskit>=0.42.1",

Should it not be that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's to prevent this issue in a test:

qiskit.exceptions.QiskitError: "Error decomposing node of instruction 'rx': 'NoneType' object has no attribute 'global_phase'. Unable to define instruction 'u' in the basis."

Though @timmysilv, have you tried fixing the issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have not, but I figured this week isn't the best time to do it. i'll give it a shot today

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

turns out Qiskit/qiskit#9343 changed the behaviour of the "unroller" transpilation method option to account for target ops, and this broke RX badly. the intention of the test is only to show that we can pass custom transpilation options, so I've changed it to just use the "translator" option! those should pass with the latest qiskit (confirmed locally)

Copy link
Contributor

@trbromley trbromley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @timmysilv! Overall looks good to me. We can come back to deciding what we want to do here during the 0.33 cycle.

setup.py Outdated
@@ -22,7 +22,7 @@
long_description = fh.read()

requirements = [
"qiskit>=0.32",
"qiskit>=0.32,<=0.42.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's to prevent this issue in a test:

qiskit.exceptions.QiskitError: "Error decomposing node of instruction 'rx': 'NoneType' object has no attribute 'global_phase'. Unable to define instruction 'u' in the basis."

Though @timmysilv, have you tried fixing the issue?

Base automatically changed from pre-release-version-bump to master June 21, 2023 13:27
@rmoyard rmoyard self-requested a review June 21, 2023 20:57
Copy link
Contributor

@rmoyard rmoyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run the IBMQ integration test from this PR?

@timmysilv
Copy link
Contributor Author

@rmoyard rmoyard self-requested a review June 22, 2023 14:17
Copy link
Contributor

@rmoyard rmoyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@timmysilv timmysilv merged commit 577dc2f into master Jun 22, 2023
@timmysilv timmysilv deleted the remove-vqe-runner branch June 22, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants